Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update niRFmxNR to 22.5 #710

Merged
merged 3 commits into from
Aug 25, 2022

Conversation

Wedgetable
Copy link
Contributor

What does this Pull Request accomplish?

Updates the niRFmxNR service to the latest public API (version 22.5). New functions, attributes, and enums were added.

Breaking changes:

  • The RFMXNR_ATTR_MODACC_PHASE_TRACKING_ENABLED attribute has been replaced by RFMXNR_ATTR_MODACC_PHASE_TRACKING_MODE
  • The RFMXNR_ATTR_MODACC_TIMING_TRACKING_ENABLED attribute has been replaced by RFMXNR_ATTR_MODACC_TIMING_TRACKING_MODE

These accommodate new enum values:

  • NIRFMXNR_INT32_MODACC_PHASE_TRACKING_MODE_DISABLED = 0
  • NIRFMXNR_INT32_MODACC_PHASE_TRACKING_MODE_REFERENCE_AND_DATA = 1
  • NIRFMXNR_INT32_MODACC_PHASE_TRACKING_MODE_PTRS = 2
  • NIRFMXNR_INT32_MODACC_TIMING_TRACKING_MODE_DISABLED = 0
  • NIRFMXNR_INT32_MODACC_TIMING_TRACKING_MODE_REFERENCE_AND_DATA = 1

While the following enums have been removed:

  • NIRFMXNR_INT32_MODACC_PHASE_TRACKING_ENABLED_FALSE = 0
  • NIRFMXNR_INT32_MODACC_PHASE_TRACKING_ENABLED_TRUE = 1
  • NIRFMXNR_INT32_MODACC_TIMING_TRACKING_ENABLED_FALSE = 0
  • NIRFMXNR_INT32_MODACC_TIMING_TRACKING_ENABLED_TRUE = 1

Existing source code wishing to compile against the updated nirfmxnr.proto will need to update references to modulation accuracy phase tracking and timing tracking to use the new _MODE attributes, but existing binaries should work.

I updated calls in the driver API tests to reflect these changes as well.

Why should this Pull Request be merged?

To support applications under development that use grpc and the latest version of RFmx.

What testing has been done?

Built and ran tests. All system tests passed, except two that always fail on my test machine, and one that doesn't seem related to NR changes:

[  FAILED  ] 3 tests, listed below:
[  FAILED  ] SessionUtilitiesServiceTests.SysCfgLibraryPresent_EnumerateDevices_DevicePropertiesIncludesNameModelVendorSerialNumberProductId
[  FAILED  ] NiDCPowerDriverApiTest.CalSelfCalibrate_CompletesSuccessfully
[  FAILED  ] NiRFmxLTEDriverApiTests.ULModAccSingleCarrierFromExample_FetchData_DataLooksReasonable

Signed-off-by: KC Hawes-Domingue 🦜 <kc.hawesdomingue@ni.com>
Signed-off-by: KC Hawes-Domingue 🦜 <kc.hawesdomingue@ni.com>
Signed-off-by: KC Hawes-Domingue 🦜 <kc.hawesdomingue@ni.com>
@Wedgetable Wedgetable added the binary-breaking Change to proto file that requires client updates label Aug 25, 2022
@Wedgetable Wedgetable merged commit dc88ead into ni:main Aug 25, 2022
@Wedgetable Wedgetable deleted the users/khawesdo/update-nirfmxnr-22.5 branch August 25, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binary-breaking Change to proto file that requires client updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants