Move SessionUtilities service to session_utilities.proto file #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to use the session message definition in other projects but do not want to include SessionUtilities. SessionUtilities is not heavily used and moving to another proto file should not be disruptive to many users.
ccifra
requested review from
reckenro,
astarche and
SparkingSpork
as code owners
SparkingSpork
approved these changes
Nov 21, 2022
reckenro
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
We want to use the session message definition in other projects but do not want to include SessionUtilities. SessionUtilities is not heavily used and moving to another proto file should not be disruptive to many users.
Why should this Pull Request be merged?
General improvement to the organization of the services and messages of this project.
What testing has been done?
No behavioral changes.