Update RFmxNR (to include RFmxNR_ModAccFetchPUSCHPhaseOffsetTrace) #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tchPUSCHPhaseOffsetTrace".
WesleyTangNationalInstruments
requested review from
reckenro and
astarche
as code owners
reckenro
reviewed
Mar 27, 2023
reckenro
approved these changes
Mar 27, 2023
|
Bypassing Windows System tests as there is an active issue with the compute farm not allocating test runners as needed. @reckenro |
WesleyTangNationalInstruments
deleted the
users/wetang/UpdateNRForModAccFetchMaximumFrequencyErrorPerSlotTrace_2
branch
reckenro
pushed a commit
that referenced
this pull request
Mar 27, 2023
) (#894) * Updated NR with latest from ni-central. Most notably "RFmxNR_ModAccFetchPUSCHPhaseOffsetTrace". * Updated header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Updates niRFmxNR to latest. Metadata files were sourced from grpc-device-scrapigen (see https://github.com/ni/grpc-device-scrapigen/pull/153).
The InstrumentStudio Panels Squad implemented usage of ModAccPUSCHPhaseOffsetTrace on Friday evening. This broke InstrumentStudio's Remote Panels and caused test failures [1] [2]. These new changes to use ModAccPUSCHPhaseOffsetTrace are required for the release so it is not reasonable to just revert them. To fix InstrumentStudio's Remote Panels, we will need to update grpc-device with this entrypoint.
This PR adds the
ModAccFetchPUSCHPhaseOffsetTraceentry-point required for InstrumentStudio Remote Panels.Note that this update also adds the following attributes:
MODACC_RESULTS_PUSCH_PEAK_PHASE_OFFSET_MAXIMUMMODACC_RESULTS_PUSCH_PEAK_PHASE_OFFSET_SLOT_INDEXWhy should this Pull Request be merged?
AB#2346243
AB#2346248
What testing has been done?
Build passes.