Skip to content

Commit

Permalink
Move appearance variant to systemlink list (#142)
Browse files Browse the repository at this point in the history
Minor follow-up to #141
to move `appearanceVariant` to the correct list.
The `sl-split-button` uses a different API from nimble currently so has
a different name for the localize ignore list.

`@Input('appearance-variant') public set appearanceVariant` in nimble vs
`@Input() public appearanceVariant` for sl-split-button. Note the
difference in the `@Input` decorator configuration.
  • Loading branch information
rajsite committed May 17, 2024
1 parent 07a3d57 commit d515a0d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Move appearanceVariant to systemlink list",
"packageName": "@ni/eslint-config-angular",
"email": "rajsite@users.noreply.github.com",
"dependentChangeType": "patch"
}
4 changes: 3 additions & 1 deletion packages/eslint-config-angular/template/options.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ const ignoreAttributeSets = {
'activeid',
'appearance',
'appearance-variant',
'appearanceVariant',
'autocomplete',
'column-id',
'field-name',
Expand Down Expand Up @@ -58,6 +57,9 @@ const ignoreAttributeSets = {
'loadColumnStateBehavior',
'parentDataField',

// sl-split-button
'appearanceVariant',

// sl-query-builder
'dropdownWidth',
],
Expand Down

0 comments on commit d515a0d

Please sign in to comment.