Skip to content

Commit

Permalink
Add support for WaitForValidTimestamp to nidaqmx-python
Browse files Browse the repository at this point in the history
  • Loading branch information
DeborahOoi96 committed Jan 31, 2024
1 parent c5fddf5 commit 232b41a
Show file tree
Hide file tree
Showing 7 changed files with 52 additions and 4 deletions.
4 changes: 4 additions & 0 deletions generated/nidaqmx/_base_interpreter.py
Original file line number Diff line number Diff line change
Expand Up @@ -1649,6 +1649,10 @@ def unregister_signal_event(self, task, signal_id):
def unreserve_network_device(self, device_name):
raise NotImplementedError

@abc.abstractmethod
def wait_for_valid_timestamp(self, task, timestamp_event, timeout):
raise NotImplementedError

@abc.abstractmethod
def wait_until_task_done(self, task, time_to_wait):
raise NotImplementedError
Expand Down
8 changes: 8 additions & 0 deletions generated/nidaqmx/_grpc_interpreter.py
Original file line number Diff line number Diff line change
Expand Up @@ -3233,6 +3233,14 @@ def unreserve_network_device(self, device_name):
self._client.UnreserveNetworkDevice,
grpc_types.UnreserveNetworkDeviceRequest(device_name=device_name))

def wait_for_valid_timestamp(self, task, timestamp_event, timeout):
response = self._invoke(
self._client.WaitForValidTimestamp,
grpc_types.WaitForValidTimestampRequest(
task=task, timestamp_event_raw=timestamp_event,
timeout=timeout))
return response.timestamp

def wait_until_task_done(self, task, time_to_wait):
response = self._invoke(
self._client.WaitUntilTaskDone,
Expand Down
18 changes: 18 additions & 0 deletions generated/nidaqmx/_library_interpreter.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
from nidaqmx._lib import lib_importer, ctypes_byte_str, c_bool32, wrapped_ndpointer
from nidaqmx.error_codes import DAQmxErrors, DAQmxWarnings
from nidaqmx.errors import DaqError, DaqReadError, DaqWarning, DaqWriteError
from nidaqmx._lib_time import AbsoluteTime


_logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -5596,6 +5597,23 @@ def unreserve_network_device(self, device_name):
device_name)
self.check_for_error(error_code)

def wait_for_valid_timestamp(self, task, timestamp_event, timeout):
timestamp = _lib_time.AbsoluteTime()

cfunc = lib_importer.windll.DAQmxWaitForValidTimestamp
if cfunc.argtypes is None:
with cfunc.arglock:
if cfunc.argtypes is None:
cfunc.argtypes = [
lib_importer.task_handle, ctypes.c_int32,
ctypes.c_double,
ctypes.POINTER(_lib_time.AbsoluteTime)]

error_code = cfunc(
task, timestamp_event, timeout, ctypes.byref(timestamp))
self.check_for_error(error_code)
return timestamp.value

def wait_until_task_done(self, task, time_to_wait):
cfunc = lib_importer.windll.DAQmxWaitUntilTaskDone
if cfunc.argtypes is None:
Expand Down
12 changes: 9 additions & 3 deletions src/codegen/metadata/functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -23601,6 +23601,11 @@
},
'WaitForValidTimestamp': {
'calling_convention': 'StdCall',
'handle_parameter': {
'ctypes_data_type': 'lib_importer.task_handle',
'cvi_name': 'taskHandle',
'python_accessor': 'self._handle'
},
'parameters': [
{
'ctypes_data_type': 'ctypes.TaskHandle',
Expand Down Expand Up @@ -23639,13 +23644,14 @@
'direction': 'out',
'is_optional_in_python': False,
'name': 'timestamp',
'python_data_type': 'DateTime',
'python_data_type': 'datetime',
'python_description': 'Specifies the timestamp type to wait on.',
'python_type_annotation': 'nidaqmx.constants.DateTime',
'python_type_annotation': 'datetime',
'type': 'CVIAbsoluteTime'
}
],
'python_codegen_method': 'no',
'python_class_name': 'Task',
'python_codegen_method': 'CustomCode',
'python_description': 'DAQmx Wait for Valid Timestamp',
'returns': 'int32'
},
Expand Down
1 change: 1 addition & 0 deletions src/codegen/templates/_library_interpreter.py.mako
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ from nidaqmx._base_interpreter import BaseEventHandler, BaseInterpreter
from nidaqmx._lib import lib_importer, ctypes_byte_str, c_bool32, wrapped_ndpointer
from nidaqmx.error_codes import DAQmxErrors, DAQmxWarnings
from nidaqmx.errors import DaqError, DaqReadError, DaqWarning, DaqWriteError
from nidaqmx._lib_time import AbsoluteTime


_logger = logging.getLogger(__name__)
Expand Down
6 changes: 6 additions & 0 deletions src/codegen/utilities/function_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -201,11 +201,17 @@ def to_param_argtype(parameter):
# argtype to convert from unicode to bytes.
if parameter.ctypes_data_type == "ctypes.c_char_p":
return "ctypes_byte_str"
elif parameter.python_data_type == "datetime":
return "_lib_time.AbsoluteTime"
elif parameter.python_data_type == "timestampEvent":
return "ctypes.c_int32"
else:
return parameter.ctypes_data_type or parameter.python_data_type
else:
if parameter.ctypes_data_type == "ctypes.c_char_p":
return parameter.ctypes_data_type
elif parameter.python_data_type == "datetime":
return "ctypes.POINTER(_lib_time.AbsoluteTime)"
else:
return f"ctypes.POINTER({parameter.ctypes_data_type})"

Expand Down
7 changes: 6 additions & 1 deletion src/codegen/utilities/interpreter_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@
"SetTimingAttributeExTimestamp",
"SetTimingAttributeTimestamp",
"SetTrigAttributeTimestamp",
"WaitForValidTimestamp",
# Deprecated, not working
"GetAnalogPowerUpStates",
]
Expand Down Expand Up @@ -179,6 +178,8 @@ def generate_interpreter_function_call_args(function_metadata):
and function_metadata.attribute_function_type == AttributeFunctionType.SET
):
function_call_args.append(type_cast_attribute_set_function_parameter(param))
elif param.type == "CVIAbsoluteTime":
function_call_args.append(f"AbsoluteTime.from_datetime({param.parameter_name})")
else:
function_call_args.append(param.parameter_name)

Expand Down Expand Up @@ -257,6 +258,8 @@ def get_instantiation_lines_for_output(func):
instantiation_lines.append(
f"{param.parameter_name} = numpy.zeros(size, dtype={param.ctypes_data_type})"
)
elif param.type == "CVIAbsoluteTime":
instantiation_lines.append(f"{param.parameter_name} = _lib_time.AbsoluteTime()")
else:
instantiation_lines.append(f"{param.parameter_name} = {param.ctypes_data_type}()")
for param in get_interpreter_in_out_params(func):
Expand Down Expand Up @@ -354,6 +357,8 @@ def get_grpc_interpreter_call_params(func, params):
has_read_array_parameter = True
elif param.is_grpc_enum or (param.is_enum and not param.is_list):
grpc_params.append(f"{name}_raw={param.parameter_name}")
elif param.type == "CVIAbsoluteTime":
grpc_params.append(f"{name}=convert_time_to_timestamp({param.parameter_name})")
else:
if is_write_bytes_param(param):
grpc_params.append(f"{name}={param.parameter_name}.tobytes()")
Expand Down

0 comments on commit 232b41a

Please sign in to comment.