Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of tests for Buffer Property #235

Merged
merged 10 commits into from
Apr 4, 2023
Merged

Addition of tests for Buffer Property #235

merged 10 commits into from
Apr 4, 2023

Conversation

Sakthi-SM
Copy link
Contributor

What does this Pull Request accomplish?
Added a test to check for support of int32 in buffer property.

Why should this Pull Request be merged?
This implements Task 2330431: Add or verify tests for Buffer property and related data types

feat: add tests for buffer attribute
9d7c737 
Signed-off-by: Sakthi Subramanian Muthuramalingam <sakthisubramaniam@solitontech.com>
@subash-suresh
Copy link
Contributor

Rename the file name to test_buffer_properties for being consistent with the test files we are going to create in future for other property types

keer1111
keer1111 approved these changes Mar 28, 2023
View reviewed changes
tests/test_buffer_property.py Outdated Show resolved Hide resolved
tests/test_buffer_property.py Outdated Show resolved Hide resolved
@Sakthi-SM Sakthi-SM changed the title [Internal] Addition of tests for Buffer Property Addition of tests for Buffer Property Mar 28, 2023
@Sakthi-SM Sakthi-SM marked this pull request as ready for review March 28, 2023 13:39
@Sakthi-SM Sakthi-SM requested a review from bkeryan March 28, 2023 13:40
zhindes
zhindes requested changes Mar 28, 2023
View reviewed changes
tests/test_buffer_property.py Outdated Show resolved Hide resolved
Sakthi Subramanian Muthuramalingam added 2 commits March 30, 2023 15:09
fix: check for default size
571091f 
Signed-off-by: Sakthi Subramanian Muthuramalingam <sakthisubramaniam@solitontech.com>
fix: lint error
c108bef 
Signed-off-by: Sakthi Subramanian Muthuramalingam <sakthisubramaniam@solitontech.com>
@Sakthi-SM Sakthi-SM requested a review from zhindes March 30, 2023 09:46
bkeryan
bkeryan requested changes Mar 30, 2023
View reviewed changes
tests/test_buffer_property.py Outdated Show resolved Hide resolved
zhindes
zhindes approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@zhindes zhindes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy once Brad's last couple of issues are resolved

Sakthi Subramanian Muthuramalingam added 2 commits April 3, 2023 14:23
fix: resolve comments
f628394 
Signed-off-by: Sakthi Subramanian Muthuramalingam <sakthisubramaniam@solitontech.com>
fix: rename tests
cbe6b12 
Signed-off-by: Sakthi Subramanian Muthuramalingam <sakthisubramaniam@solitontech.com>
@Sakthi-SM Sakthi-SM requested a review from bkeryan April 3, 2023 10:30
bkeryan
bkeryan requested changes Apr 3, 2023
View reviewed changes
tests/test_buffer_property.py Outdated Show resolved Hide resolved
tests/test_buffer_property.py Outdated Show resolved Hide resolved
tests/test_buffer_property.py Outdated Show resolved Hide resolved
Sakthi Subramanian Muthuramalingam added 2 commits April 4, 2023 17:33
fix: alignment changes
ecbe335 
Signed-off-by: Sakthi Subramanian Muthuramalingam <sakthisubramaniam@solitontech.com>
fix: lint errors
69eac6f 
Signed-off-by: Sakthi Subramanian Muthuramalingam <sakthisubramaniam@solitontech.com>
@Sakthi-SM Sakthi-SM requested a review from bkeryan April 4, 2023 12:36
bkeryan
bkeryan requested changes Apr 4, 2023
View reviewed changes
tests/test_buffer_property.py Outdated Show resolved Hide resolved
tests/test_buffer_property.py Outdated Show resolved Hide resolved
fix: move to component tests
95a1f74 
Signed-off-by: Sakthi Subramanian Muthuramalingam <sakthisubramaniam@solitontech.com>
@ni ni deleted a comment from bkeryan Apr 4, 2023
fix: remove test
1c5a6e1 
Signed-off-by: Sakthi Subramanian Muthuramalingam <sakthisubramaniam@solitontech.com>
zhindes
zhindes requested changes Apr 4, 2023
View reviewed changes
tests/component/test_buffer_property.py Outdated Show resolved Hide resolved
@Sakthi-SM Sakthi-SM requested a review from zhindes April 4, 2023 17:07
@zhindes zhindes merged commit 23ced54 into master Apr 4, 2023
@Sakthi-SM Sakthi-SM deleted the users/sakthi/add-tests-buffer branch May 31, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkeryan bkeryan bkeryan approved these changes

@zhindes zhindes zhindes approved these changes

@keer1111 keer1111 keer1111 approved these changes

@subash-suresh subash-suresh subash-suresh approved these changes

@maxxboehme maxxboehme Awaiting requested review from maxxboehme maxxboehme is a code owner

Assignees
No one assigned
Labels
test_improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Sakthi-SM @subash-suresh @bkeryan @zhindes @keer1111