Add Offset Nulling Calibration API support for nidaqmx-python #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeborahOoi96
requested review from
zhindes,
maxxboehme and
bkeryan
as code owners
zhindes
reviewed
Jan 5, 2024
zhindes
approved these changes
Jan 9, 2024
bkeryan
requested changes
Jan 10, 2024
bkeryan
reviewed
Jan 10, 2024
bkeryan
requested changes
Jan 11, 2024
bkeryan
approved these changes
Jan 12, 2024
DeborahOoi96
force-pushed
the
users/deooi/daqmx-python-1
branch
from
ddfa2d8
to
367c4ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
We want to include support for Offset Nulling Calibration API in python.
This PR adds support for the following C functions in python
DAQmxPerformBridgeOffsetNullingCalEx
DAQmxPerformThrmcplLeadOffsetNullingCal
Also added regression test coverage to ensure that these functions behave as expected.
To make the regression test for DAQmxPerformThrmcplLeadOffsetNullingCal work, I had to add a new simulated device 9214 in the simulated cDAQ chassis as all other devices do not support performing thermocouple lead offset nulling calibration.
Why should this Pull Request be merged?
It provides support for the Offset Nulling Calibration functions in python
What testing has been done?
Regression tests added, all pass successfully in my test machine.
