Refactor Task Internal Modules: Triggers #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charitylxy
requested review from
zhindes,
maxxboehme and
bkeryan
as code owners
bkeryan
changed the title
bkeryan
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR aims to address issue brought up in #461:
nidaqmx._task_modulespackage.task.pyinto a package and merge it with the internal modules contained innidaqmx._task_modulesRefactoring work will be split into 5 PRs:
_task.pyand_in_stream.py- Refactor task.py and internal module (in_stream.py) #534_export_signal.py,_out_stream.py,_timing.py- Refactor Task Internal Modules (ExportSignal, OutStream, Timing) #539_channel_collection.py,_ai_channel_collection.py,_ao_channel_collection.py,_ci_channel_collection.py,_co_channel_collection.py,_di_channel_collection.py,_do_channel_collection.py- Refactor Task Internal Modules: Collections #541_channel.py,_ai_channel.py,_ao_channel.py,_ci_channel.py,_co_channel.py,_di_channel.py,_do_channel.py- Refactor Task Internal Modules: Channels #544_triggers.py,_arm_start_trigger.py,_handshake_trigger.py,_pause_trigger.py,_reference_trigger.py,_start_trigger.pyWhy should this Pull Request be merged?
In this PR to address #461, following changes have been made:
triggeringtotaskpackage and made its modules private.triggersand it's subobjectsxxx_trigger.What testing has been done?
Ran
poetry run pytestand all tests passed.