Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component tests for Global Chans, Task Done, and Watchdog #548

Merged
merged 20 commits into from
Mar 26, 2024
Merged

Component tests for Global Chans, Task Done, and Watchdog #548

merged 20 commits into from
Mar 26, 2024

Conversation

texasaggie97
Copy link
Collaborator

@texasaggie97 texasaggie97 commented Mar 21, 2024 •
edited

What does this Pull Request accomplish?

Adds components tests for calling the following DAQmx functions:

  • DAQmxAddGlobalChansToTask
  • DAQmxIsTaskDone
  • DAQmxCfgWatchdogAOExpirStates
  • DAQmxCfgWatchdogCOExpirStates
  • DAQmxControlWatchdogTask
  • DAQmxSaveGlobalChan

Implementation

  • Change simulated cDAQ chassis to 9189 (more slots)
  • Add simulated cDAQ modules 9263 and 9401
  • Add tests that call listed functions

Why should this Pull Request be merged?

This is a step towards more complete testing

What testing has been done?

All tests pass locally

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2024 •
edited

Test Results

    34 files  ±    0      34 suites  ±0   43m 17s ⏱️ +13s
 2 244 tests +  176   1 908 ✅ +  207    336 💤  -  31  0 ❌ ±0 
39 650 runs  +2 978  34 114 ✅ +3 512  5 536 💤  - 534  0 ❌ ±0 

Results for commit f86cf46. ± Comparison against base commit d5b5636.

This pull request removes 32 and adds 208 tests. Note that renamed tests count towards both. 
tests.component.system._collections.test_physical_channel_collection ‑ test___physical_channels___getitem_str___shared_interpreter[grpc_init_kwargs-ai_physical_chans]
tests.component.system._collections.test_physical_channel_collection ‑ test___physical_channels___getitem_str___shared_interpreter[grpc_init_kwargs-ao_physical_chans]
tests.component.system._collections.test_physical_channel_collection ‑ test___physical_channels___getitem_str___shared_interpreter[grpc_init_kwargs-ci_physical_chans]
tests.component.system._collections.test_physical_channel_collection ‑ test___physical_channels___getitem_str___shared_interpreter[grpc_init_kwargs-co_physical_chans]
tests.component.system._collections.test_physical_channel_collection ‑ test___physical_channels___getitem_str___shared_interpreter[grpc_init_kwargs-di_lines]
tests.component.system._collections.test_physical_channel_collection ‑ test___physical_channels___getitem_str___shared_interpreter[grpc_init_kwargs-di_ports]
tests.component.system._collections.test_physical_channel_collection ‑ test___physical_channels___getitem_str___shared_interpreter[grpc_init_kwargs-do_lines]
tests.component.system._collections.test_physical_channel_collection ‑ test___physical_channels___getitem_str___shared_interpreter[grpc_init_kwargs-do_ports]
tests.component.system._collections.test_physical_channel_collection ‑ test___physical_channels___getitem_str___shared_interpreter[library_init_kwargs-ai_physical_chans]
tests.component.system._collections.test_physical_channel_collection ‑ test___physical_channels___getitem_str___shared_interpreter[library_init_kwargs-ao_physical_chans]
…

tests.component.system._collections.test_physical_channel_collection ‑ test___physical_channels___getitem_mixed_str_list___name[grpc_init_kwargs-ai_physical_chans]
tests.component.system._collections.test_physical_channel_collection ‑ test___physical_channels___getitem_mixed_str_list___name[grpc_init_kwargs-ao_physical_chans]
tests.component.system._collections.test_physical_channel_collection ‑ test___physical_channels___getitem_mixed_str_list___name[grpc_init_kwargs-ci_physical_chans]
tests.component.system._collections.test_physical_channel_collection ‑ test___physical_channels___getitem_mixed_str_list___name[grpc_init_kwargs-co_physical_chans]
tests.component.system._collections.test_physical_channel_collection ‑ test___physical_channels___getitem_mixed_str_list___name[grpc_init_kwargs-di_lines]
tests.component.system._collections.test_physical_channel_collection ‑ test___physical_channels___getitem_mixed_str_list___name[grpc_init_kwargs-di_ports]
tests.component.system._collections.test_physical_channel_collection ‑ test___physical_channels___getitem_mixed_str_list___name[grpc_init_kwargs-do_lines]
tests.component.system._collections.test_physical_channel_collection ‑ test___physical_channels___getitem_mixed_str_list___name[grpc_init_kwargs-do_ports]
tests.component.system._collections.test_physical_channel_collection ‑ test___physical_channels___getitem_mixed_str_list___name[library_init_kwargs-ai_physical_chans]
tests.component.system._collections.test_physical_channel_collection ‑ test___physical_channels___getitem_mixed_str_list___name[library_init_kwargs-ao_physical_chans]
…

♻️ This comment has been updated with latest results.

zhindes
zhindes requested changes Mar 21, 2024
View reviewed changes
tests/component/test_task.py Outdated Show resolved Hide resolved
tests/component/test_watchdog.py Outdated Show resolved Hide resolved
tests/component/test_watchdog.py Outdated Show resolved Hide resolved
tests/component/test_watchdog.py Outdated Show resolved Hide resolved
@zhindes zhindes changed the title Additional Component tests Component tests for Global Chans, Task Done, and Watchdog Mar 21, 2024
zhindes
zhindes previously requested changes Mar 21, 2024
View reviewed changes
tests/max_config/nidaqmxMaxConfig.ini Outdated Show resolved Hide resolved
texasaggie97 and others added 2 commits March 21, 2024 13:43
@texasaggie97 @zhindes
Update tests/max_config/nidaqmxMaxConfig.ini
bad5bd3 
Co-authored-by: Zach Hindes <zach.hindes@ni.com>
@texasaggie97
Review comments
f48f83e
bkeryan
bkeryan previously requested changes Mar 21, 2024
View reviewed changes
tests/component/system/storage/test_persisted_channel.py Outdated Show resolved Hide resolved
tests/component/system/storage/test_persisted_channel.py Outdated Show resolved Hide resolved
tests/component/test_task.py Outdated Show resolved Hide resolved
tests/component/test_task.py Outdated Show resolved Hide resolved
tests/component/test_task_properties.py Outdated Show resolved Hide resolved
tests/component/test_task_properties.py Outdated Show resolved Hide resolved
tests/component/test_watchdog.py Outdated Show resolved Hide resolved
bkeryan
bkeryan reviewed Mar 21, 2024
View reviewed changes
tests/component/test_watchdog.py Show resolved Hide resolved
tests/component/test_watchdog.py Outdated Show resolved Hide resolved
tests/component/test_watchdog.py Show resolved Hide resolved
tests/component/test_watchdog.py Outdated Show resolved Hide resolved
@texasaggie97 texasaggie97 dismissed bkeryan’s stale review March 25, 2024 14:17

Comments addressed

bkeryan
bkeryan approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

tests/component/system/storage/test_persisted_channel.py Outdated Show resolved Hide resolved
tests/component/test_watchdog.py Outdated Show resolved Hide resolved
tests/component/test_watchdog.py Outdated Show resolved Hide resolved
tests/component/test_watchdog.py Outdated Show resolved Hide resolved
tests/component/test_watchdog.py Outdated Show resolved Hide resolved
texasaggie97 and others added 2 commits March 25, 2024 13:20
@texasaggie97 @bkeryan
Update tests/component/system/storage/test_persisted_channel.py
04add5f 
Co-authored-by: Brad Keryan <brad.keryan@ni.com>
@texasaggie97 @bkeryan
Update tests/component/test_watchdog.py
3a9b5f6 
Co-authored-by: Brad Keryan <brad.keryan@ni.com>
texasaggie97 and others added 4 commits March 25, 2024 13:20
@texasaggie97 @bkeryan
Update tests/component/test_watchdog.py
b8f797b 
Co-authored-by: Brad Keryan <brad.keryan@ni.com>
@texasaggie97 @bkeryan
Update tests/component/test_watchdog.py
a3c0f95 
Co-authored-by: Brad Keryan <brad.keryan@ni.com>
@texasaggie97 @bkeryan
Update tests/component/test_watchdog.py
cda7493 
Co-authored-by: Brad Keryan <brad.keryan@ni.com>
@texasaggie97
Fix lint issues
f86cf46
@maxxboehme maxxboehme merged commit a60f369 into master Mar 26, 2024
17 checks passed
@texasaggie97 texasaggie97 deleted the users/texasaggie97/more-task-tests branch March 26, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxxboehme maxxboehme maxxboehme approved these changes

@bkeryan bkeryan bkeryan approved these changes

@zhindes zhindes zhindes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@texasaggie97 @maxxboehme @bkeryan @zhindes