-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error reporting in some cases #550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woops, did a single comment before. see my comment about inverting the message order
Test Results 34 files ± 0 34 suites ±0 41m 33s ⏱️ + 1m 10s Results for commit a41ab87. ± Comparison against base commit e902251. This pull request removes 32 and adds 192 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Commets addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit on the string when the description can't be found.
Co-authored-by: Zach Hindes <zach.hindes@ni.com>
What does this Pull Request accomplish?
If for some reason the extended error message is blank, the
DaqError
ends up not showing any output when it is printed. This can happen if the DLL doesn't properly load plugins. If message is blank, try to put at least something in to the message that is then given to the parent Error class.Changed
DaqReadError
andDaqWriteError
to letDaqError
handle setting the messageWhy should this Pull Request be merged?
Improves error reporting
What testing has been done?
Local testing