Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After the fact feedback from PR #558 #564

Merged

Conversation

texasaggie97
Copy link
Collaborator

There was feedback that came in after #558 was completed. This handles that feedback.

What does this Pull Request accomplish?

  • Rename new tests to better inform what they are doing
  • Move calls that cause expected asserts and warnings to "assert" section
  • Raise timeout to 10 seconds when waiting on semaphore

Why should this Pull Request be merged?

What testing has been done?

PR

Copy link

Test Results

    34 files  ±0      34 suites  ±0   47m 22s ⏱️ + 4m 2s
 2 248 tests ±0   1 910 ✅ ±0    338 💤 ±0  0 ❌ ±0 
39 690 runs  ±0  34 134 ✅ ±0  5 556 💤 ±0  0 ❌ ±0 

Results for commit 97c5eb9. ± Comparison against base commit 06da4f4.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.
tests.component.test_task_events ‑ test___done_event_registered___call_clear_in_callback___stop_close_in_callback_with_success_status[grpc_init_kwargs]
tests.component.test_task_events ‑ test___done_event_registered___call_clear_in_callback___stop_close_in_callback_with_success_status[library_init_kwargs]
tests.component.test_task_events ‑ test___every_n_samples_event_registered___call_clear_in_callback___stop_close_in_callback_with_success_status[grpc_init_kwargs]
tests.component.test_task_events ‑ test___every_n_samples_event_registered___call_clear_in_callback___stop_close_in_callback_with_success_status[library_init_kwargs]
tests.component.test_task_events ‑ test___done_event_registered___call_stop_close_in_callback___task_closed_with_success_status[grpc_init_kwargs]
tests.component.test_task_events ‑ test___done_event_registered___call_stop_close_in_callback___task_closed_with_success_status[library_init_kwargs]
tests.component.test_task_events ‑ test___every_n_samples_event_registered___call_stop_close_in_callback___task_closed_with_success_status[grpc_init_kwargs]
tests.component.test_task_events ‑ test___every_n_samples_event_registered___call_stop_close_in_callback___task_closed_with_success_status[library_init_kwargs]
This pull request removes 2 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.
tests.component.test_task_events ‑ test___done_event_registered___call_clear_in_callback___stop_close_in_callback_with_success_status[grpc_init_kwargs]
tests.component.test_task_events ‑ test___every_n_samples_event_registered___call_clear_in_callback___stop_close_in_callback_with_success_status[grpc_init_kwargs]
tests.component.test_task_events ‑ test___done_event_registered___call_stop_close_in_callback___task_closed_with_success_status[grpc_init_kwargs]
tests.component.test_task_events ‑ test___every_n_samples_event_registered___call_stop_close_in_callback___task_closed_with_success_status[grpc_init_kwargs]

@texasaggie97 texasaggie97 merged commit 31a89b5 into master Apr 15, 2024
17 checks passed
@texasaggie97 texasaggie97 deleted the users/texasaggie97/test-clearing-task-in-callback-feedback branch April 15, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants