Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tsconfig.json when Storybook issue is resolved #219

Closed
fredvisser opened this issue Dec 3, 2021 · 2 comments · Fixed by #399
Closed

Update tsconfig.json when Storybook issue is resolved #219

fredvisser opened this issue Dec 3, 2021 · 2 comments · Fixed by #399
Assignees
@m-akinc
Labels
bug Something isn't working

Comments

@fredvisser
Copy link
Contributor

When storybookjs/storybook#16839 is resolved, we should reenable library checking in the tsconfig.json.

I.e. From –

// Set to True to workaround – https://github.com/storybookjs/storybook/issues/16839
"skipLibCheck": true,

To –

"skipLibCheck": false,
@fredvisser fredvisser added blocked Blocked on a third-party issue bug Something isn't working labels Dec 3, 2021
@fredvisser fredvisser mentioned this issue Dec 3, 2021
Merged
1 task
@m-akinc m-akinc removed the blocked Blocked on a third-party issue label Dec 20, 2021
@m-akinc
Copy link
Contributor

m-akinc commented Dec 20, 2021

Looks like the linked storybook issue is resolved in version 6.4.9, so no longer blocked. I tried to update the storybook dependencies in my local repo, but couldn't figure it out. Neither npm update storybook nor npm update storybook -w packages/nimble-components did anything.

@rajsite
Copy link
Member

rajsite commented Jan 7, 2022

@m-akinc storybook is broken up into several packages: https://github.com/ni/nimble/blob/main/packages/nimble-components/package.json#L55

If you know the version to bump them to it can be easier to update the lower bound of the version of the package and run npm install at the repo root

@m-akinc m-akinc self-assigned this Mar 1, 2022
@m-akinc m-akinc mentioned this issue Mar 1, 2022
Merged
1 task
m-akinc added a commit that referenced this issue Mar 3, 2022
@m-akinc
Update Storybook and remove skipLibCheck (#399)
cf2cc70 
## 🤨 Rationale

Fixes #219 

## 👩‍💻 Implementation

The Storybook issue was resolved in version 6.4.9, so I updated all Storybook dependencies at version 6.4.0 to 6.4.9 in nimble-components. Then I removed the `skipLibCheck: true` setting from `tsconfig.json`.

## 🧪 Testing

Updated imports locally and built without error.

## ✅ Checklist

- [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-akinc m-akinc

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Storybook and remove skipLibCheck ni/nimble
3 participants
@fredvisser @rajsite @m-akinc