Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to official Storybook 7 release #1147

Merged
merged 8 commits into from
Apr 12, 2023
Merged

Conversation

jattasNI
Copy link
Contributor

@jattasNI jattasNI commented Mar 31, 2023

Pull Request

🤨 Rationale

Right after I submitted the upgrade to a release candidate of Storybook 7 in #1134, I noticed they released the official 7.0.0. Adopting the latest patch addresses some of the issues in #1146.

👩‍💻 Implementation

  1. Update to latest non-RC build in package.json and regenerate package-lock.json
  2. Regenerate one patch file since the file it was patching has a new name
  3. Add another patch file since they introduced another instance of [Bug]: 7.0.0-rc.8 Cannot find module 'lib/types/dist' in @storybook/html storybookjs/storybook#21820
  4. Move off deprecated API for specifying sourceTransform as described in migration guide
  5. Delete storybook-declarations.ts since this bug was closed [Bug]: 7.0.0 - Module '"@storybook/addon-actions/decorator"' has no exported member 'withActions' storybookjs/storybook#21887

🧪 Testing

Explored Storybook.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@jattasNI jattasNI marked this pull request as ready for review April 12, 2023 22:09
@rajsite rajsite merged commit 25071e6 into main Apr 12, 2023
4 checks passed
@rajsite rajsite deleted the users/jattas/storybook-released branch April 12, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: 7.0.0 - Module '"@storybook/addon-actions/decorator"' has no exported member 'withActions'
2 participants