Suppress Circular Dependencies Warnings related to D3 #1501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
The d3 library chooses to intentionally keep circular dependencies: d3/d3-selection#168
Rollup reports circular dependencies as warnings but to limit verbosity only show the first few so all we see are warnings related to d3. Example:
If we introduce circular dependencies or add a library that introduces additional circular dpendencies they may be missed.
π©βπ» Implementation
Implemented a rollup onwarn handler that can filter out the d3 libraries circular dependency warnings.
π§ͺ Testing
Validated locally that choosing a more specific prefix like
d3-selection
will filter only warnings for that subset and let others through.β Checklist