Update some 3rd party dependencies to latest and re-enable 'npm audit' #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jattasNI
changed the title
rajsite
approved these changes
Jun 6, 2022
1 task
rajsite
pushed a commit
that referenced
this pull request
Jun 16, 2022
# Pull Request ## 🤨 Rationale I noticed a critical vulnerability being reported when running `npm i` in Skyline `Web/Packages`. It's the same vulnerability that we fixed in #589 but coming from `beachball-lock-update` instead of `beachball` directly. We missed updating `beachball-lock-update` in that PR because its dependency was a `peerDependency` so vulnerabilities aren't reported by `npm audit`. ## 👩💻 Implementation Update `beachball` version to same used by the rest of the repo and run `npm install`. ## 🧪 Testing Relying on pipeline. ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Fixes #581. We had disabled
npm auditin our pipelines because of the vulnerability, but beachball published a fix this weekend: microsoft/beachball#666.👩💻 Implementation
npm auditcommands inmain.yml. This revealed new vulnerabilities in severaldevDependencies:ejs,event-source, andjson-schema.npm updatefor each of the above dependencies and alsojsprim, which was needed to get the fixedjson-schema(jsprimpins its deps to exact versions)I looked into npm overrides which are intended for this purpose but they're not ready for prime time (poorly documented workspace support and bizarrely not usable with an existing package-lock.json with our current npm version.
🧪 Testing
Relying on pipeline.
✅ Checklist