Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove clear_error() from nidigital API #1366

Closed
sbethur opened this issue Apr 2, 2020 · 0 comments · Fixed by #1372
Closed

Remove clear_error() from nidigital API #1366

sbethur opened this issue Apr 2, 2020 · 0 comments · Fixed by #1372
Assignees
@sbethur
Labels
API nidigital
Milestone
nidigital API fin...

Comments

@sbethur
Copy link
Contributor

sbethur commented Apr 2, 2020

Description of issue

In nimi-python APIs, errors are handled internally and only exceptions are exposed via API. There is no need for clear_error in public API.
@sbethur sbethur added this to the nidigital API finalization milestone Apr 2, 2020
@sbethur sbethur self-assigned this Apr 2, 2020
@sbethur sbethur mentioned this issue Apr 2, 2020
Merged
2 tasks
sbethur added a commit that referenced this issue Apr 2, 2020
@sbethur
Remove test_clear_error(). clear_error() will be removed (#1366).
d672da2
marcoskirsch pushed a commit that referenced this issue Apr 3, 2020
@sbethur
Add system tests for nidigital utility methods (#1365)
297343f 
* Add system tests for nidigital utility methods

Tests added:
- test_reset
- test_reset_device
- test_self_test
- test_get_error
- test_clear_error
- test_self_calibrate

* Remove test_clear_error(). clear_error() will be removed (#1366).
@sbethur sbethur mentioned this issue Apr 5, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbethur sbethur

Labels
API nidigital
Projects
None yet
Milestone
nidigital API finalization
Development

Successfully merging a pull request may close this issue.

Remove clear_error() from nidigital API ni/nimi-python
1 participant
@sbethur