chore: add pydantic plugin for mypy (#54)

ni · Apr 9, 2024 · a842173 · a842173
1 parent 0532466
commit a842173
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 15 deletions.
diff --git a/examples/dataframe/create_write_data.py b/examples/dataframe/create_write_data.py
@@ -18,9 +18,9 @@
     CreateTableRequest(
         name="Example Table",
         columns=[
-            Column(name="index", dataType=DataType.Int32, columnType=ColumnType.Index),
-            Column(name="Float_Column", dataType=DataType.Float32),
-            Column(name="Timestamp_Column", dataType=DataType.Timestamp),
+            Column(name="ix", data_type=DataType.Int32, column_type=ColumnType.Index),
+            Column(name="Float_Column", data_type=DataType.Float32),
+            Column(name="Timestamp_Column", data_type=DataType.Timestamp),
         ],
     )
 )

diff --git a/examples/spec/query_specs.py b/examples/spec/query_specs.py
@@ -73,7 +73,7 @@
 # You can query specs based on any field using DynamicLinq syntax.
 # These are just some representative examples.
 
-response = client.query_specs(QuerySpecificationsRequest(productIds=[product]))
+response = client.query_specs(QuerySpecificationsRequest(product_ids=[product]))
 all_product_specs = response.specs
 
 # Query based on spec id

diff --git a/mypy.ini b/mypy.ini
@@ -2,6 +2,7 @@
 mypy_path=nisystemlink/stubs
 files=nisystemlink,tests
 warn_unused_configs=True
+plugins = pydantic.mypy
 
 [mypy-nisystemlink.*]
 disallow_untyped_calls=True

diff --git a/tests/integration/spec/test_spec.py b/tests/integration/spec/test_spec.py
@@ -119,8 +119,8 @@ def test__create_single_spec__one_created_with_right_field_values(
         specId = uuid.uuid1().hex
         productId = product
         spec = SpecificationDefinition(
-            productId=productId,
-            specId=specId,
+            product_id=productId,
+            spec_id=specId,
             type=SpecificationType.FUNCTIONAL,
             keywords=["work", "reviewed"],
             category="Parametric Specs",
@@ -141,8 +141,8 @@ def test__create_multiple_specs__all_succeed(
         specs = []
         for id in specIds:
             spec = SpecificationDefinition(
-                productId=productId,
-                specId=id,
+                product_id=productId,
+                spec_id=id,
                 type=SpecificationType.FUNCTIONAL,
                 keywords=["work", "reviewed"],
                 category="Parametric Specs",
@@ -159,8 +159,8 @@ def test__create_duplicate_spec__errors(
         duplicate_id = uuid.uuid1().hex
         productId = product
         spec = SpecificationDefinition(
-            productId=productId,
-            specId=duplicate_id,
+            product_id=productId,
+            spec_id=duplicate_id,
             type=SpecificationType.FUNCTIONAL,
             keywords=["work", "reviewed"],
             category="Parametric Specs",
@@ -180,8 +180,8 @@ def test__delete_existing_spec__succeeds(self, client: SpecClient, product):
         specId = uuid.uuid1().hex
         productId = product
         spec = SpecificationDefinition(
-            productId=productId,
-            specId=specId,
+            product_id=productId,
+            spec_id=specId,
             type=SpecificationType.FUNCTIONAL,
         )
         response = client.create_specs(CreateSpecificationsRequest(specs=[spec]))
@@ -202,8 +202,8 @@ def test__update_single_same_version__version_updates(
         self, client: SpecClient, create_specs, product
     ):
         spec = SpecificationDefinition(
-            productId=product,
-            specId="spec1",
+            product_id=product,
+            spec_id="spec1",
             type=SpecificationType.FUNCTIONAL,
             keywords=["work", "reviewed"],
             category="Parametric Specs",
@@ -238,7 +238,7 @@ def test__update_single_same_version__version_updates(
     def test__query_product__all_returned(
         self, client: SpecClient, create_specs, create_specs_for_query, product
     ):
-        request = QuerySpecificationsRequest(productIds=[product])
+        request = QuerySpecificationsRequest(product_ids=[product])
 
         response = client.query_specs(request)
         assert response.specs