feat: Method to update table metadata #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the DFS code, we call the patch route |
spanglerco
approved these changes
Nov 29, 2022
cameronwaterman
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
update_table_metdatamethod to patch table metdata.The behavior of setting
nullto remove properties/fields relies on Pydantic'sexclude_unsetconfig: https://pydantic-docs.helpmanual.io/usage/exporting_models/What testing has been done?
Open Issues
Does anyone have input on the naming for the patch methods? I wasn't sure what to go with.
modify_table_metadatamodify_table(s)patch_table(s)Keep in mind that we will need a name for the multi-patch method as well.