feat: Implement create/get/delete/list table metadata methods #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mure
commented
Nov 16, 2022
mure
commented
Nov 16, 2022
cameronwaterman
requested changes
Nov 16, 2022
There was a problem hiding this comment.
Please change your title to adhere to the Angular style
i.e. "feat: Implement create/get/delete table metadata methods"
It looks like there is also a typo in your existing title 馃槅
mure
changed the title
cameronwaterman
approved these changes
Nov 16, 2022
spanglerco
reviewed
Nov 16, 2022
There was a problem hiding this comment.
Some test ideas:
- Validate we deserialize timestamps correctly by asserting the created_at on the table metadata. We would probably need some kind of threshold for allowed values given that the time on the server may not match the time on the client.
- Retrieve metadata for a valid table ID that doesn't exist (like
000000000000000000000000) and verify we raise the correct exception that includes the error details like the code and args. - Similarly, we could have an error case for the create and delete APIs.
|
@spanglerco @cameronwaterman I was working off this branch and since the PR is still up, I went ahead and added the list_tables method as well. I'll reset the reviews so y'all can take a look. New changes: 20f3bbf |
mure
changed the title
spanglerco
requested changes
Nov 17, 2022
Co-authored-by: Paul Spangler <spanglerco@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Implements a set of table metadata routes:
Adds a custom serializer for our Pydantic models. This is so we can set certain options like
by_alias.Switches attribute comments to use docstrings, because some of them wouldn't fit on a single line.
Why should this Pull Request be merged?
We need this functionality.
(This part of the PR template is awkward. I'm never sure what to put other than "because we need it")
What testing has been done?
Added our first functional test 馃帀 Feel free to suggest other test cases. I think we'll want at least one that tests an expected error.