feat: Add query-tables method #32
Conversation
| @@ -41,7 +42,7 @@ def _handle_http_status(response: Response) -> Optional[Response]: | |||
| @dumps.to_json(JsonModel) | |||
| def _deserialize_model(model_cls: Type[JsonModel], model_instance: JsonModel) -> Dict: | |||
| """Turns a :class:`.JsonModel` instance into a dictionary for serialization.""" | |||
| return model_instance.dict(by_alias=True, exclude_unset=True) | |||
| return json.loads(model_instance.json(by_alias=True, exclude_unset=True)) | |||
There was a problem hiding this comment.
Working around this issue: pydantic/pydantic#1409
tl;dr: calling dict() on a model doesn't serialize datetimes like json() does, but the converter is expecting a dictionary.
| between now and the start of the current year | ||
| """ | ||
|
|
||
| substitutions: Optional[List[Union[StrictInt, StrictBool, str, None]]] = None |
There was a problem hiding this comment.
It could be interesting to explore having the API accept datetime (and maybe something representing a TimeSpan) values and serializing them to strings in the correct format.
There was a problem hiding this comment.
So client-side substitutions for Python objects? That sounds useful - I'll keep it in mind.
There was a problem hiding this comment.
Yep. Could be worth adding a task/story. Similar to how we want to support a helper for reading and writing row data as native types instead of only strings.
I added more filters to the test. |
What does this Pull Request accomplish?
Why should this Pull Request be merged?
What testing has been done?