Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Prepare for 1.0.0 release #41

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

cameronwaterman
Copy link
Collaborator

@cameronwaterman cameronwaterman commented Dec 14, 2022

What does this Pull Request accomplish?

Prepare for 1.0.0 release. This will be considered a breaking change.

Why should this Pull Request be merged?

We are ready for a 1.0.0 release.

What testing has been done?

None

Copy link
Collaborator

@spanglerco spanglerco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this actually trigger a 1.0.0 release or are we wanting to wait on that?

@cameronwaterman
Copy link
Collaborator Author

Will this actually trigger a 1.0.0 release or are we wanting to wait on that?

Adding BREAKING CHANGE: <message> to the commit footer will trigger a build of a new major version.

It was my understanding we want to build a 1.0.0 release now that we have docs and have done some preliminary testing. Please correct me if I'm wrong in that.

@cameronwaterman cameronwaterman merged commit c61925c into master Dec 15, 2022
@cameronwaterman cameronwaterman deleted the users/cwaterma/create-1.0-release branch December 15, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants