Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coupling Mode and Bus Selection to System Explorer, Scripting and Engine #22

Merged
merged 2 commits into from
May 19, 2022

Conversation

papowerNI
Copy link
Contributor

@papowerNI papowerNI commented May 19, 2022

What does this Pull Request accomplish?

  • Adds Bus Selection and Coupling Mode to the Device Parameters.
  • Also cleans up Initialize Bus Controller, although not related.

Why should this Pull Request be merged?

Bus Coupling is necessary for AIM 1553.

What testing has been done?

Test suite works (device parameters is already tested, so this gets lumped into those tests).
Also ran manual tests to read and write a word from Ballard -> AIM. When coupling mode is incompatible, the read/write does not go through, but when the coupling mode is compatible, it does.

Since a system test requires Ballard->AIM I did not add a system automated test for this. It could be added to a cross-compatible system test suite in the future.

With Correct Coupling:
image

With Incompatible coupling:
image

@niveristand-diff-bot
Copy link
Collaborator

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Custom Device.lvlib--Initialize Bus Controller.vi.png

capture

AIM MIL-STD-1553 Engine.lvlib--Custom Device.lvlib--Initialize Hardware.vi.png

capture

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Construct.vi.png

capture

AIM MIL-STD-1553 Hardware API.lvlib--Initialize 1553 Module.vi.png

capture

AIM MIL-STD-1553 Hardware API.lvlib--Set Device Coupling.vi.png

capture

AIM MIL-STD-1553 Scripting.lvlib--Constants.vi.png

capture

AIM MIL-STD-1553 Scripting.lvlib--Get Device Parameters.vi.png

capture

AIM MIL-STD-1553 Scripting.lvlib--Set Device Parameters.vi.png

capture

AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Device Parameters to Configuration Elements.vi.png

capture

AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Initialize.vi.png

capture

AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Main Page.vi.png

capture

Create Execution Unit.lvclass--test BC + RTs.vi.png

capture

Create Execution Unit.lvclass--test BC Only.vi.png

capture

Create Execution Unit.lvclass--test RTs Only.vi.png

capture

Deployment.lvclass--globalSetUp.vi.png

capture

Logging Loopback.lvclass--Script Custom Device.vi.png

capture

Loopback.lvclass--globalSetUp.vi.png

capture

Scripting.lvclass--test Get-Set-Get Device Parameters.vi.png

capture

Copy link
Collaborator

@buckd buckd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Bus Selection.ctl and Coupling Mode.ctl need to be added to the project.

@niveristand-diff-bot
Copy link
Collaborator

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Custom Device.lvlib--Initialize Bus Controller.vi.png

capture

AIM MIL-STD-1553 Engine.lvlib--Custom Device.lvlib--Initialize Hardware.vi.png

capture

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Construct.vi.png

capture

AIM MIL-STD-1553 Hardware API.lvlib--Initialize 1553 Module.vi.png

capture

AIM MIL-STD-1553 Hardware API.lvlib--Set Device Coupling.vi.png

capture

AIM MIL-STD-1553 Scripting.lvlib--Constants.vi.png

capture

AIM MIL-STD-1553 Scripting.lvlib--Get Device Parameters.vi.png

capture

AIM MIL-STD-1553 Scripting.lvlib--Set Device Parameters.vi.png

capture

AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Device Parameters to Configuration Elements.vi.png

capture

AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Initialize.vi.png

capture

AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Main Page.vi.png

capture

Create Execution Unit.lvclass--test BC + RTs.vi.png

capture

Create Execution Unit.lvclass--test BC Only.vi.png

capture

Create Execution Unit.lvclass--test RTs Only.vi.png

capture

Deployment.lvclass--globalSetUp.vi.png

capture

Logging Loopback.lvclass--Script Custom Device.vi.png

capture

Loopback.lvclass--globalSetUp.vi.png

capture

Scripting.lvclass--test Get-Set-Get Device Parameters.vi.png

capture

@papowerNI papowerNI merged commit e1e9c4b into main May 19, 2022
@Karl-G1 Karl-G1 deleted the dev/add-bus-coupling branch June 3, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants