Work around BIU buffer ID allocation with simple offset #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize Hardware.vi.png
|
|
Note this is going to conflict with active PR #51 - which ever one gets pushed first, we should make sure the other doesn't overwrite it |
buckd
approved these changes
Jul 11, 2022
Karl-G1
force-pushed
the
dev/work_around_buffers
branch
from
0667a27
to
5511726
Compare
|
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize Hardware.vi.png
|
papowerNI
approved these changes
Jul 11, 2022
This was referenced Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Temporarily work around #50 with a simple offset based on BIU number
Essentially limits buffer ID allocation to 2000 per BIU
Why should this Pull Request be merged?
Enable multi-BIU testing
What testing has been done?
Deployed a simple configuration (from #50) to 2x BIUs on the same module.