Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loopback test #8

Merged
merged 4 commits into from Nov 14, 2018
Merged

Add loopback test #8

merged 4 commits into from Nov 14, 2018

Conversation

csjall
Copy link
Contributor

@csjall csjall commented Nov 13, 2018

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Add first system level test for SLSC 12201 custom device. Fix broken unit test.

Why should this Pull Request be merged?

Augment unit test with system level tests.

What testing has been done?

2018_11_13_14_21_15 VI Tester.txt

@rtzoeller
Copy link
Contributor

rtzoeller commented Nov 13, 2018

testLoopback.vi

  • Wire up the error terminals for GetProperty.vi and SetMultipleChannelValues.vi
  • The error wire goes under these VIs, not through them
    image
  • Where do the 99/98 values come from, and why do they differ? Shouldn't they be the same?

@niveristand-diff-bot
Copy link
Collaborator

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

SLSC 12201 System Tests.lvclass--FIlobb_setUp.vi.png: capture

SLSC 12201 System Tests.lvclass--FSMBV9_tearDown.vi.png: capture

SLSC 12201 System Tests.lvclass--qVJZc9_testLoopback.vi.png: capture

SLSC 12201 Unit Tests.lvclass--G2hPXa_test Connector Pane.vi.png: capture

@csjall csjall merged commit 99f1163 into master Nov 14, 2018
@csjall csjall deleted the dev/tests branch November 14, 2018 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants