fix(CI): Hold back flake8 version #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flake8 3.4 was recently released and [broke support for ignoring multiple items on a line](https://gitlab.com/pycqa/flake8/issues/356).
Flake8 breaking nixnet is finally motivating me to switch our builds to lock dependencies. This is just the first step, moving the dependencies into a dedicated file.
This has the benefit of pinning or locking every dependency so we have stable builds and are easily upgraded (through piptools's pip-compile or pyup) in a controlled way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake8 3.4 was recently released and broke support for ignoring multiple
items on a line.
toxsuccessfully runs, including unit tests and style checks (see CONTRIBUTING.md).