feat(cli): report using both area and trace names

nialov · Sep 6, 2023 · 08ebf47 · 08ebf47
1 parent 370741b
commit 08ebf47
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/tests/test_cli.py b/tests/test_cli.py
@@ -341,6 +341,9 @@ def test_all_cli(ready_tracerepository: Path):
 
     # Make sure pandera error was caught
     assert "Reported" in validate_result.stdout
+    assert "kb" in validate_result.stdout
+    assert "traces" in validate_result.stdout
+    assert "area" in validate_result.stdout
     assert "html" in validate_result.stdout
     assert reports_path.exists()
     assert len(list(reports_path.glob("*.html"))) > 0

diff --git a/tracerepo/cli.py b/tracerepo/cli.py
@@ -199,6 +199,7 @@ def validate(
                 pandera_report=pandera_report,
                 report_directory=report_directory,
                 area_name=update_tuple.area_name,
+                traces_name=update_tuple.traces_path.stem,
             )
             console.print(str_report)
 

diff --git a/tracerepo/utils.py b/tracerepo/utils.py
@@ -349,17 +349,20 @@ def filename_friendly_datetime_string() -> str:
 
 
 def report_pandera_errors(
-    pandera_report: pd.DataFrame, report_directory: Path, area_name: str
+    pandera_report: pd.DataFrame,
+    report_directory: Path,
+    area_name: str,
+    traces_name: str,
 ) -> str:
     """
     Report pandera errors as html files saved to a reports directory.
     """
     report_directory.mkdir(exist_ok=True)
     current_time = filename_friendly_datetime_string()
-    report_name = f"{area_name}_report_{current_time}.html"
+    report_name = f"{area_name}_{traces_name}_report_{current_time}.html"
     report_path = report_directory / report_name
     pandera_report.to_html(report_path)
-    return f"Reported {area_name} traces pandera errors to {report_path}."
+    return f"Reported pandera errors to {report_path}."
 
 
 def otherwise_valid(update_tuple: UpdateTuple) -> bool: