Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node.js 10.x and fix security vulnerabilities #14

Merged
merged 3 commits into from Jul 16, 2019

Conversation

nicklaw5
Copy link
Contributor

@nicklaw5 nicklaw5 commented Jul 16, 2019

Fixing this:

Screen Shot 2019-07-16 at 3 54 54 pm

Also:

  • Upgrade to Node.js 10.x
  • Update Eslint to v6.x
  • Use default Eslint rules rather than third-party ruleset
  • Update mocha to v6.x
  • Include package-lock.json file to avoid regressions

@nicklaw5 nicklaw5 force-pushed the fix-eslint-security-issues branch 4 times, most recently from 9496fd6 to dd80c71 Compare July 16, 2019 06:24
@nicklaw5 nicklaw5 changed the title Fix security vulnerabilities Upgrade to Node.js 10.x and fix security vulnerabilities Jul 16, 2019
- Update Eslint to v6.x
- Use default Eslint rules rather than third-party ruleset
- Update mocha to v6.x
- Include package-lock.json file to avoid regressions
- Use babel as Eslint parser
Node.js 6.10 is now deprecated and no longer supported by AWS.
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@hlmartin hlmartin merged commit fe75aef into master Jul 16, 2019
@nicklaw5 nicklaw5 deleted the fix-eslint-security-issues branch July 16, 2019 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants