Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails because of missing keystore.properties #9

Closed
sudheesh001 opened this issue May 26, 2020 · 10 comments
Closed

Build fails because of missing keystore.properties #9

sudheesh001 opened this issue May 26, 2020 · 10 comments

Comments

@sudheesh001
Copy link

sudheesh001 commented May 26, 2020

The gradle build of the project looks for a keystore.properties file, which is missing from the checked in codebase.

def keystorePropertiesFile = rootProject.file("keystore.properties")
def keystoreProperties = new Properties()
keystoreProperties.load(new FileInputStream(keystorePropertiesFile))

While the details are mentioned in the readme, please checkin a default file as is which needs to be configured by the developers running the build.

@Chinmay-KB
Copy link

If you read the readme.MD carefully you'll see they have mentioned it to create a keystore.properties in the root directory

Modi ji should rezine XD

@sudheesh001
Copy link
Author

please checkin a default file as is which needs to be configured by the developers running the build.

The suggestion was this. Please take a look at the issue again.

@sudheesh001
Copy link
Author

Closing in favor of #16 which was the right way to ask this.

@anirudh-chhangani
Copy link

having a default file sounds like a reasonable suggestion.

@LavHinsu
Copy link

author of #16 here. this should've been thought out by developers before releasing the source code, because unless you fix this or implement a api (if you successfully implement one, let me know), there's actually no way to compile this.

@sudheesh001
Copy link
Author

Thank you, I agree with this. I agree that I might have suggested this very poorly in my original issue report but this is definitely a blocker and not an unreasonable ask. Maybe provide the APIs to a mock sandbox server to begin with?

@manojnagendra
Copy link

author of #16 here. this should've been thought out by developers before releasing the source code, because unless you fix this or implement a api (if you successfully implement one, let me know), there's actually no way to compile this.

Does commenting out the release build instructions fix the issue, at least for now?

@LavHinsu
Copy link

author of #16 here. this should've been thought out by developers before releasing the source code, because unless you fix this or implement a api (if you successfully implement one, let me know), there's actually no way to compile this.

Does commenting out the release build instructions fix the issue, at least for now?

Nope, tried it. fails. even with a firebase.json added. probably because it was not built with a demo/fake api in mind. why even release the code if no one alive except them could compile it?

@HaneetGH
Copy link

1.create keystore.properties in project folder
2.update the content as per read.me
3.update build.gradle
4. def keystorePropertiesFile = rootProject.file("./keystore.properties")

start build

at least code compiles

@LavHinsu
Copy link

LavHinsu commented May 26, 2020

even if you do this, all the api responses will result in errors or 404s resulting in either the app crashing or You not being able to get past the login screen.

delhiamitk pushed a commit that referenced this issue Jun 1, 2020
Known android BT adapter not on crash handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants