Android CI #39
Open
Android CI #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have added github actions code for running Android CI with placeholder files for
|
|
You may have to create google-services.json.sample and keystore-properties.sample and add In build steps to avoid conflicting with actual config files |
|
Updated with sample files to avoid conflicts |
|
Squash your commits please. |
./gradlew assembleDebug Create keystore.properties Create google-services.json Update google-services.json Rename google-services.json to app/google-services.json Update android.yml Update google-services.json Update android.yml Update google-services.json Update Contributors.md if it merges, my name would automatically get added to contributors.md Rename keystore.properties to keystore.properties.sample Rename app/google-services.json to google-services.json.sample Update android.yml Update android.yml
|
Squashed commits into 1 |
phoenix24
approved these changes
May 27, 2020
|
Unit tests are written for some modules, worth adding that gradle Task to CI ? |
add test
|
Added test command to ci |
Co-authored-by: HARSHIT GUPTA <harshitsaamu@gmail.com>
aravindvnair99
approved these changes
May 27, 2020
saikatharryc
approved these changes
May 28, 2020
|
Who can merge this? Does anybody know? |
@ahujamoh Only owner and collaborators can merge. So only one of them if I'm right: @niharika2810 |
|
@delhiamitk can you please merge this? |
|
I believe they will not merge any PRs or solve any issues over here as this is like a piece of reference for encouraging the bug bounty program and making the source code open.
The project is not being maintained using GitHub over here.
…On Sun, May 31, 2020 at 6:26 PM Mohit Ahuja ***@***.***> wrote:
@delhiamitk <https://github.com/delhiamitk> can you please merge this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#39 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADFM5VQOCDJWI4UAYFZIPU3RUJHYPANCNFSM4NK74L7A>
.
--
Thanks and Regards,
Subhrodip Mohanta. <https://subho.xyz>
|
ohbus
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.