Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not save plants with only default entries #34

Closed
niccokunzmann opened this issue Aug 11, 2018 · 4 comments · Fixed by #219
Closed

Do not save plants with only default entries #34

niccokunzmann opened this issue Aug 11, 2018 · 4 comments · Fixed by #219
Labels
bug Something isn't working Nicco does not want to solve this Nicco will probably not do that

Comments

@niccokunzmann
Copy link
Owner

If a plant was not edited, just has the fields from the start

  • delete this plant when the new plant activity is closed
  • stop GPS position updates on the plant as they are no use
niccokunzmann added a commit that referenced this issue Aug 11, 2018
- stop when plant is deleted
- check if plant is deleted
- fix #29
- related #34
@niccokunzmann niccokunzmann added the bug Something isn't working label Aug 16, 2018
@niccokunzmann niccokunzmann added the Nicco does not want to solve this Nicco will probably not do that label Aug 27, 2018
@Marky25
Copy link
Contributor

Marky25 commented Oct 15, 2018

Hi Nicco, as this issue is open, I would try to fix it.

If I understand this correctly, when user wants to save new plant, but with no change of its data, the plant should be deleted from collection as well as the location updates should be disabled on this plant ?

Thank's for your reply and cheers :-)

@niccokunzmann
Copy link
Owner Author

@Marky25 Yes, this is correct!

@Marky25
Copy link
Contributor

Marky25 commented Oct 15, 2018

Okay, great ;-)
I'll drop questions here if needed and create pull-request when done.
I'm a newbie at GitHub, so let's see what we can do here :-D

Marky25 added a commit to Marky25/mundraub-android that referenced this issue Nov 1, 2018
@Marky25
Copy link
Contributor

Marky25 commented Nov 1, 2018

Hi Nicco,
I've come with a solution for this issue and hope that it is what you've expected :-D
And there is one more thing I have in mind which came out during development.
It will be nice, if user gets feedback (in form of short message), that his plant was not saved.
Probably, this can be done in another issue. What do you think ? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Nicco does not want to solve this Nicco will probably not do that
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants