Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to provide configuration yaml url #13

Closed
thoka opened this issue Feb 15, 2019 · 6 comments
Closed

Add option to provide configuration yaml url #13

thoka opened this issue Feb 15, 2019 · 6 comments

Comments

@thoka
Copy link

thoka commented Feb 15, 2019

Consider to provide configuration of the calendar by an URL, pointing to some publicly available yaml or json file.

Benefits:

  • nice support for big calendars
  • add features like templates / color coding of events
  • config file could be group editable beeing served from a github repository

We're using Polar.sh so you can upvote and help fund this issue. We receive the funding once the issue is completed & confirmed by you. Thank you in advance for helping prioritize & fund our work. Fund with Polar
@niccokunzmann
Copy link
Owner

Yes, this is there. It needs to be documented. It is a JSON file. the URL parameter is specification.

@niccokunzmann
Copy link
Owner

niccokunzmann commented Feb 16, 2019

@thoka #6 is closed now. Would you vote for YML? You can have a look, create new issues and close this one if appropriate.

@thoka
Copy link
Author

thoka commented Feb 17, 2019

Hm. The main benefit of yaml are comments inside code and better readability.

Are there any drawbacks ?

@niccokunzmann
Copy link
Owner

niccokunzmann commented Feb 17, 2019

Are there any drawbacks ?

Hm. No.

We can use yml with safe_load. Would you agree to the following?


We can close the issue if

  • it is possible to load the calendar specification as yml, too
  • it is documented that we can load the specification as yml
  • we can choose the yml format for specification on the index page or there is an issue for this
  • should there be an example yml file which includes comments and can be used as documentation?

niccokunzmann added a commit that referenced this issue Mar 3, 2019
@niccokunzmann
Copy link
Owner

@thoka I pushed some functionality. Do you think this issue can be closed? What do you think should be done to close this issue?

@niccokunzmann
Copy link
Owner

I do not want to further this. We can re-open or make new issues for yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants