Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Ruff linter and formatter and pre-commit #136

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

fabien-michel
Copy link
Collaborator

This PR setup ruff code linter and formatter.
I choose to apply all ruff rules and ignore some i've picked up to have a balance between expected conventions and current code state.
The configuration is in the pyproject.toml file.

I've updated all files so they are formatted and pass the linter rules.

It also setup pre-commit to have to code auto fixed and formatted on git commit.

This add two dev dependencies : ruff and pre-commit. Should I create a dev-requirements.txt ?


.. code-block:: shell

pre-commit install
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would do it, I guess... So I can try that out!

@niccokunzmann niccokunzmann merged commit 8602b4e into niccokunzmann:main Apr 5, 2024
7 checks passed
@niccokunzmann
Copy link
Owner

niccokunzmann commented Apr 5, 2024

This add two dev dependencies : ruff and pre-commit. Should I create a dev-requirements.txt ?

I do not know. It does not seem necessary. I will try out the documentation and see if I can set it up. If not, I can open an issue or PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants