Fix handling of modified recurrences with lower sequence number than their base event #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
the current implementation assumes that a modified recurrence has a higher sequence number than its base event. However, this is not always the case, as modifying the base event after creating a modified recurrence does only increase the sequence number of the base event.
This pull request fixes this behavior by also using the presents of the
sequence ID
field to determine if an event replaces another one. I am not sure if this behavior is according to the specification, but this topic seems to be highly controversial as stated in this article: https://icalevents.com/4437-correct-handling-of-uid-recurrence-id-sequence/Best regards,
dstolpmann