Create callbacks to be used for async. calls. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data layer tasks (IO tasks) should always be ran on a thread different from the main thread. This will allow us to follow the callback pattern to integrate in asynchronous (or mocked async.) IO tasks in the future. This is the first step in completing the PTR feature. ISSUE #1
niccorder
commented
Jul 2, 2018
| * | ||
| * @param <T> type of the data in the response. | ||
| */ | ||
| public abstract class RepositoryCallback<T> implements SuccessCallback<T>, ErrorCallback { |
There was a problem hiding this comment.
SuccessCallback and ErrorCallback look like they might add in unnecessary overhead at this point in time.
It looks great to me, and let's add a task once the MVP is done to circle back and see if SuccessCallback and ErrorCallback are adding in overhead at a later time 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data layer tasks (IO tasks) should always be ran on a thread different
from the main thread. This will allow us to follow the callback pattern
to integrate in asynchronous (or mocked async.) IO tasks in the future.
This is the first step in completing the PTR feature.
ISSUE #1