Implement asynchronous PTR functionality. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to be able to PTR in the application to see if there has been any new data since they have last checked the news. This currently has the data layer mocked out, and mimics a network call by delaying a response for 200L. ISSUE #1
niccorder
commented
Jul 2, 2018
| @NonNull | ||
| @Override | ||
| public List<Category> getAllCategories() { | ||
| return Arrays.asList( | ||
| BUSINESS, | ||
| TECHNOLOGY, | ||
| POLITICS, | ||
| SPORTS | ||
| SPORTS, | ||
| WORLD |
There was a problem hiding this comment.
Thanks for the bug-fix 💯 Next time, lets keep our PR's as to the point as possible to we can better track what changes are being made. For this PR it's fine though!
Thanks again 😄
niccorder
commented
Jul 2, 2018
| // DiffUtil is a utility provided by the android support libraries to calculate the | ||
| // diff between two lists for us. Thankfully, it also works seamlessly with a recyclerview | ||
| // adapter as you will see below. | ||
| final DiffUtil.DiffResult diffResult = DiffUtil.calculateDiff(new DiffUtil.Callback() { |
There was a problem hiding this comment.
This should be fine for the MVP, but we will need to create a task to calculate the Diff on the background thread. If we calculate the diff on the main thread, it will definitely lock up the UI for larger lists.
Looks good for this PR though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to be able to PTR in the application to see if there
has been any new data since they have last checked the news. This
currently has the data layer mocked out, and mimics a network call by
delaying a response for 200L.
ISSUE #1