NXT-124 History fix #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h getProjectDetail not returning an empty array when indevref is not valid
ediblecode
approved these changes
Dec 5, 2022
kavithanice
pushed a commit
that referenced
this pull request
May 4, 2023
… branch) (#74) * NXT-100 Setup basic server side props and data fetching for indicators detail * NXT-100 Compare slug to product title and redirect accordingly if there's no match * NXT-100 Add type predicate for error responses, mock getProductDetail, add unit test todos. * NXT-100 Clarify comment * NXT-100 Fix incorrect title redirect unit test * NXT-100 Fix broken unit test for incorrect title * NXT-100 Add unit test for id does not exist * NXT-100 Add unit tests for unhyphenated slug and non existent product id * NXT-100 Add snapshot test for IndicatorDetailsPage * turn on node experimental-vm-modules mode * NXT-100 Remove experimental flag from test script * NXT-100 Swap needle for axios - wip * NXT-100 Add h1 for indicator product title. Continue debugging axios - wip * NXT-100 Add isolatedModules property for ts-jest to temporarily prevent typechecking * NXT-100 Setup types and feed for chapter info. Fix typescript issues * NXT-100 Refactor typescript types for embedded properties and chapter detail page. Fix typescript issues * NXT-100 Use axios mock adapter to wrap client. Fix types (underscores etc) after removing the preservedKeys option on axios-case-converter applyCaseMiddleware call * NXT-100 Remove it.only * NXT-100 Create chapter menu component and populate with urls with correct structure. Correct remaining refactored property from _links to links * NXT-100 Dangerously set innterHTML for overview and chapter detail pages content * NXT-100 Add Next-Previous component from nice design system * NXT-100 Add unit tests for publicationsChapterMenu * NXT-100 Introduce stacked nav component to publicationsChapterMenu * NXT-100 Add snapshot test for publicationsChapterMenu. Temporarily comment out failing aspects of tests * NXT-100 Mock useRouter in PublicationsChapterMenu unit tests. Add test for lowercasing of url * NXT-100 Add unit test for highlighting functionality of PublicationsChapterMenu * NXT-100 Remove debugging in template * NXT-100 Build chapters and links array - wip * NXT-100 Move chapter objects path calculation out of PublicationChapterMenu component * NXT-100 Populate next page link for overview page * NXT-100 Simplify logic for nextPage link on overview page. Styling for layout on overview page. Add unit test for uppercasing of id in page header meta data. Add dateTime attr for time tag in page header meta data * NXT-100 Add SEO component to populate page title. Add unit test for page title * NXT-100 Remove TODO comments. Add metadescription to SEO component. * NXT-100 Add unit tests for page meta data and PageHeader lead meta data. Format datetime attr with dayjs * NXT-100 Remove redundant unit tests from PublicationChapterMenu * NXT-100 Change mark-up for PageHeader lead meta due to issue with invalid DOM nesting * NXT-100 Update overview page snapshot * NXT-100 Remove commented out code * NXT-100 Add Last updated meta item to PageHeader * NXT-100 Add spaces to date meta items in PageHeader * NXT-100 Add module style to override default PageHeader paragraph width limit * NXT-100 Remove placeholder markup from chapterSlug page * NXT-100 Remove unused dependency from chapter detail page * NXT-100 Mock axios and modify unit test for publications.test. Remove deprecated PromiseValue from ts-fest and replace with built-in Await keyword * NXT-100 Update publications unit tests with axios mock and mock data * NW-1805 Indicators sitemap.xml (#76) * NW-1805 Add XML sitemap generation for indicators * NW-1805 Fix tests etc * NW-1805 Fix scss linting * NW-1805 Fix tests * NW-1805 Add server timing header for sitemap XML * NW-1805 Fix sitemap base path * NW-1805 Add sitemap link for indicators pages * NXT-100 Add unit tests for published/last updated date display. Update types for productDetail. Make mock product data more flexible in unit tests * NXT-100 Update unit tests to account for nbsp; in meta data date items with rtl getDefaultNormalizer) * NXT-100 Remove unused deps from unit test file * NXT-100 Remove unused module styles, filter metaData arr to remove null entries and prevent an empty list item being generated for them by the pageHeader component * NXT-100 Update product details type with missing fields from api. Update mockdata product detail example to account for new type information * NXT-100 Refine metadata filtering arg * NXT-100 Remove unused parameter from chapters and links building function * NXT-100 Reinstate chapters and links function productType parameter * NXT-100 Remove unused productType param from chapters and links building function * NXT-100 Add aria label for chapter menu * NXT-100 Refactoring after code review * NXT-100 Refactor to make await calls parallel. Use getProductPath from utils for redirect url * NXT-100 Minor refactor after code review * NXT-100 Refactor mocking in unit tests. Refacor getServerSideProps logic to eliminate unneccessary calls for productType data * NXT-100 TS linting fixes * NXT-112 Indicator chapter pages (#78) * NXT-112 Remove product type arg from chapters and links building function * NXT-112 Remove unnecessary props on chapter detail * NXT-112 Layout shared components for chapter detail page - wip * NXT-112 Add breadcrumb and PrevNext component to page * NXT-112 Populate prevNext component props dynamically * NXT-112 Add unit tests for getServerSideProps and next/prev links * NXT-112 Add missing property for HTMLChapterContent type * NXT-112 Refactor chapter pagination logic prior to moving into its own component * NXT-112 Refactor chapters pagination and move into its own component * NXT-112 Add unit tests for chapters overview stacked nav item generation. Refactor unit tests for Previous and Next pagination to use toHaveAccessibleName * NXT-112 Clarify mock data filename so it isn't confused with guidance * NXT-112 Remove commented out unit test. Remove default export for PublicationsPrevNext component * NXT-112 Change chapterContent immediate child selector for div to only target the first instance * NXT-112 Change span to div as divs can't be children of spans * NXT-112 Minor refactoring and clean up from PR conversations * NXT-112 Small refactor of prev/next * NXT-112 Refactor chapter tests * NXT-112 Tidy up Co-authored-by: Ian Routledge <ian.routledge@nice.org.uk> * NXT-114 Indicator sub type metadata (#77) * NXT-114 Add feed logic for indicator sub types * NXT-114 Start adding meta tags * NXT-114 Add indicator sub type to meta data. Merge NXT-100 * NXT-114 Add unit tests for additional meta tagging. Simplify indicator sub type list enum content access * NXT-114 Move indicator sub type enum to types.ts and import from there * NXT-114 Get indicator sub types from API and mock into unit tests * NXT-114 Make await functions parallel instead of series * NXT-114 Harcoded indicatorSubTypes assertion for getServerSideProps unit test * NXT-114 Remove debugging from overview page. Reduce amount of hardcoded assertion data in gSSP unit test * NXT-114 Refactor meta tag generation for subtypes * NXT-114 Update unit test for type meta tags to cover multiples * NXT-114 Add unit test for schema.DCTERMS link tag Co-authored-by: John Davey <john.davey@nice.org.uk> * NXT-112 Use chapterSlug and title from nicePublicationsChapterContentInfo to fix issue where chapter urls from product.chapterHeadings don't map correctly to desired chapter paths (#80) * NXT-114 Indicator sub type (#81) * NXT-114 Add feed logic for indicator sub types * NXT-114 Start adding meta tags * NXT-114 Add indicator sub type to meta data. Merge NXT-100 * NXT-114 Add unit tests for additional meta tagging. Simplify indicator sub type list enum content access * NXT-114 Move indicator sub type enum to types.ts and import from there * NXT-114 Get indicator sub types from API and mock into unit tests * NXT-114 Make await functions parallel instead of series * NXT-114 Harcoded indicatorSubTypes assertion for getServerSideProps unit test * NXT-114 Remove debugging from overview page. Reduce amount of hardcoded assertion data in gSSP unit test * NXT-114 Refactor meta tag generation for subtypes * NXT-114 Update unit test for type meta tags to cover multiples * NXT-114 Add unit test for schema.DCTERMS link tag * NXT-114 Add keyOverride to enable render of multiple meta tags of the same name: DCTERMS.type * NXT-114 Reduce server cache times Co-authored-by: Ian Routledge <ian.routledge@nice.org.uk> * NXT-119 Indicator PDF download button (#79) * NXT-119 Initial setup for download link * NXT-119 Add spacing below download button * NXT-119 Add Indicator filename to download link, remove fileType prop * NXT-119 Change download link * NXT-119 Move download link styles to component * NXT-119 Minor refactor. Add unit test * NXT-119 Add unit tests for download link button * NXT-119 Add indicator download link to chapter page * NXT-119 Update snapshots * wip * wip * NXT-119 Remove nested link from download link button * NXT-119 Create function to get publication download path * NXT-119 unit test for publication download path utility function - wip * NXT-119 Add unit test for getPublicationDownloadPath utility function * NXT-119 Remove commented out lines * NXT-119 Use getProductPath for root path in getPublicationDownloadPath * NXT-119 Import ProductGroup from types rather than the publications module as it is currently being used in client side rendering * NXT-119 Update snapshot * NXT-119 Simplify and rename get publication download file function. Move the function from render block to server side props * NXT-119 Add basic file stream methods * NXT-119 Add PDF serving route * NXT-119 Change publications download link to use anchor instead of button * NXT-119 Remove unused uid const. Rename publicationsDownloadLink style module file * NXT-119 Update unit tests to reflect changes to markup and pdf file download path/props * NXT-119 Duplicate code for pdf download link on chapter page. Update unit tests * NXT-119 Refactor indicator details pages * NXT-119 Move utils around and tidy download button * NXT-119 Fix snapshots * NXT-119 Open download link in new tab * NXT-119 Fix snapshots Co-authored-by: Ian Routledge <ian.routledge@nice.org.uk> * NXT-112 indicator chapter pages (#82) * NXT-112 Remove product type arg from chapters and links building function * NXT-112 Remove unnecessary props on chapter detail * NXT-112 Layout shared components for chapter detail page - wip * NXT-112 Add breadcrumb and PrevNext component to page * NXT-112 Populate prevNext component props dynamically * NXT-112 Add unit tests for getServerSideProps and next/prev links * NXT-112 Add missing property for HTMLChapterContent type * NXT-112 Refactor chapter pagination logic prior to moving into its own component * NXT-112 Refactor chapters pagination and move into its own component * NXT-112 Add unit tests for chapters overview stacked nav item generation. Refactor unit tests for Previous and Next pagination to use toHaveAccessibleName * NXT-112 Clarify mock data filename so it isn't confused with guidance * NXT-112 Remove commented out unit test. Remove default export for PublicationsPrevNext component * NXT-112 Change chapterContent immediate child selector for div to only target the first instance * NXT-112 Change span to div as divs can't be children of spans * NXT-112 Minor refactoring and clean up from PR conversations * NXT-112 Small refactor of prev/next * NXT-112 Refactor chapter tests * NXT-112 Tidy up * NXT-112 Import styles from nice design system for panel and table so chapter content html is correctly styled * NXT-112 Setup types for HTMLChapterSectionInfo * NXT-112 Generate on this page link list * NXT-112 Change undefined to null to see if it fixes issue with chapterSections prop in getServerSideProps * NXT-112 Refactor to reduce amount of data passed around in props * NXT-112 Change logic around chapter sections ternary to satisfy typescript expectations on getServerSideProps. Add unit tests for PublicationsChapterSectionsList component. * NXT-112 Add chapter slug page title and unit test * NXT-112 Swap bespoke on this page menu for more generic version from BNF * NXT-112 Lint scss and refactor OnThisPage section formatting to happen server side. Remove BNF specific spacing from OnThisPage component * NXT-112 Introduce reverse layout for chapter pages with 'OnThisPage' component * NXT-112 Add extra grid to overview page to prevent layout shift when switching between overview and chapter pages * NXT-112 Update snapshots * NXT-112 Remove unnecessary cast to unknown * NXT-112 Refactoring * NXT-112 Add unit tests for on this page in chapter slug * NXT-112 Add unit test for chapterSections prop value * NXT-112 Remove unused import * NXT-112 Change privately scoped vars in OnThisPage module to see if it passes linting on TeamCity * NXT-112 Update stylelintrc.json to match the BNF version. Reinstate scoped vars in OnThisPage.module.scss * NXT-112 Reinstate previous stylelint rules. Modify OnThisPage scss module vars to use format * NXT-112 Remove scoped scss vars to see if it fixes issue with chapter details not displaying on alpha * NXT-112 Revert changes to scss variable scoped names * NXT-112 Switch striptags to a dependency rather than a devdep as it was lifted from BNF which has no runtime * NXT-112 Small refactors * NXT-112 Fix tests Co-authored-by: Ian Routledge <ian.routledge@nice.org.uk> * NXT-112 indicator chapter pages hydration fix (#86) * NXT-112 use isClient hook to prevent errors with SSR verus client side rendering mismatches on hydration * NXT-112 Strip hash from asPath to resolve differences in ssr and client rendering for isCurrent prop * NXT-112 Remove unused const * NXT-112 Replace hash on asPath to resolve issue with ssr and client rendering differences on hydrate phase * NXT-112 Set asPath on mock useRouter * NXT-112 Remove empty fragment from PublicationsChapterMenu * NXT-101 Indicator list pages (#83) * NXT-101 Make search index a prop in GuidanceListServerSideProps * NXT-101 Generate breadcrumbs from breadcrumbsTrail arg passed to getGuidanceListPage. Update guidance and indicators pages to use new format * NXT-101 Abstract GuidanceListNav for use in indicators and guidance * NXT-101 Refactor abstractions of listnav and breadcrumbs, wip * NXT-101 Refactor abstraction of breadcrumb and list nav to remaining pages. Update unit tests. Add pageheader lead and preheading for Indicators * NXT-101 Add unit tests for IndicatorListNav * NXT-101 Rename all occurrences of GuidanceListPage to ProductListPage and GuidanceListNav to ProductListNav and move directories * NXT-101 Further renaming to change references to GuidanceList to ProductList for consts, props, types * NXT-101 Remove lead from pageHeader for inconsultation and indevelopment indicators * NXT-101 Add meta descriptions for indicators list pages. Remove unused import for Link as lead which contains a link is now dropped from in consultation and in development list pages * NXT-101 Remove lead from pageHeader and move the text into an intro prop * NXT-101 Corrections for table columns, captions and titles * NXT-101 Provide correct data for columns based on indicator type, wip * NXT-101 Corrections for table contents * NXT-101 Match live design system version to resolve issue with Results Per Page List not aligning right Co-authored-by: Ian Routledge <ian.routledge@nice.org.uk> * NXT-120 Indicator tools and resources and evidence index pages (#84) * NXT-120 Initial work on tools and resources * NXT-120 Add product menu * NXT-120 Add array utils * NXT-120 Add 404 IFP placeholder * NXT-120 Add resource list * NXT-120 Reorder props * NXT-120 Small tweaks * NXT-120 Add caching to resource details * NXT-120 Small refactor * NXT-120 Add resource util tests * NXT-120 Add comments * NXT-120 Small refactor * NXT-120 Refactor tools and resources * NXT-120 Improve validate route params * NXT-120 Improve comment * NXT-120 Remove commented code * NXT-121 Highlight standards and indicators (#87) * NXT-121 Add Main wrapper component from global nav * Revert "NXT-121 Add Main wrapper component from global nav" This reverts commit d601dd3. * NXT-121 Calculate service for global nav highlight based on pathname * NXT-121 Move switch case inline for service highlight * NXT-121 Mock Main from global nav so it renders a basic main tag with children and generates less noise in tests * NXT-121 Add global scss to zero out margin on global nav footer to avoid gap with back-to-top * NXT-121 Remove global nav mocking from copyToClipboard unit test file. Rename scss file so it is easily associated with _app.page * NXT-124 Indicator history tab (#89) * NXT-124 Add placeholder file for history * NXT-124 Create structure for history page * NXT-124 Retrieve inDevReference for product * NXT-124 Get project detail from inDev wip * NXT-124 Add types for inDev projectDetail * NXT-124 First draft of indev projectDetail types * NXT-124 List panel titles wip * NXT-124 List inDev resources * NXT-124 Filter panels on showPanel boolean * NXT-124 Flatten file properties into panels * NXT-124 history wip * NXT-124 History wip * NXT-124 History wip * NXT-124 History wip * NXT-124 History wip * NXT-124 Render resources for history, omit file info for textOnly resources * NXT-124 Clean up rendering for history tab. Correct types for IndevPanel to account for fact that niceIndevResource property can be a single IndevResource or an array of them. Add early return logic to clean up object notation and homogenize HistoryResource type to allow simpler mapping in getServerSideProps * NXT-124 Correction to HistoryResource type * NXT-124 Convert history page to use ResourceList component * NXT-124 Remove unused 'panels' prop * NXT-124 Move project const into validateRouteParams * NXT-124 Get project from product indevreference * NXT-124 Move isErrorResponse check for getProjectDetail into api * NXT-124 Remove commented code from inDev.ts * NXT-124 Refactoring wip * NXT-124 Refactoring meta data display for html results. Result sorting * NXT-124 Remove unused embed types from indev.ts. Add breadcrumb, pageHeader and horizontal nav * NXT-124 Add OnThisPage menu wip * NXT-124 Add grid layout for OnThisPage wip * NXT-124 Remove unused index param from map * NXT-124 Reinstate index param to map * NXT-124 Account for duplicate titles in OnThisPage anchor ids * NXT-124 Slug placeholders for indev pdf and html * NXT-124 Basic unit test setup * NXT-124 Remove console log line * NXT-124 Remove console log * NXT-124 Add page title * NXT-124 unit test for page title * NXT-124 Update snapshot * NXT-124 Add unit test for hasHistory prop * NXT-124 Create file stream for pdf and html resourceFile content * NXT-124 Remove unused imports. Add last updated date for resource html page * NXT-124 Add filter condition for showInDocList resources only * NXT-124 Add breadcrumbs for history page and html resource page * NXT-124 Add resource lists for [htmlPath]. Unit testing setup for htmlPath * NXT-124 Initial unit tests for [htmlPath] page * NXT-124 Add getServerSideProps unit tests for [htmlPath] page * NXT-124 Add unit tests for history downloadPath and htmlPath. Return not found on history page when there are no history panels. Add spacing for resource list on history to match live * NXT-124 Add resource list type to unit test assertions. Remove hardcoded 'NA' indevReference from mockdata * NXT-124 Minor amends for to address PR comments * NXT-124 Check for error response in getProjectDetail to fix issue with getProjectDetail not returning an empty array when indevref is not valid (#91) * NXT-126 Tools and resources downloads and HTML pages (#88) * NXT-126 Tools and resources downloads * NXT-126 Add download tests * NXT-126 Fix tests * NXT-126 Fix download paths * NXT-126 Add editable resource page and tests * NXT-126 Fix tests * NXT-126 Add resource download links * NXT-126 Fix tests * NXT-126 Add resource chapter pages * NXT-126 Post merge fixes * NXT-126 Add resource card tests * NXT-126 Add file size tests * NXT-126 Add smooth scrolling * NXT-126 Refactor resource list with tests * NXT-126 Refactor resource list pages * NXT-126 Refactor resource list pages * NXT-126 Fix tests * NXT-126 Add common feed mock logic * NXT-127 Indicator redirects (#95) * NXT-127 Add indicator list page redirects * NXT-127 Add old indicator details page redirects * NXT-129 Indicator in development project overview tab (#94) * NXT-129 Initial setup for indev overview page including separate validateRouteParams for project * NXT-129 Add 'Complete' type for ProjectStatus. Use ProjectStatus and productPath for redirect * NXT-129 Render project timeline table * NXT-129 Populate project overview with further data * NXT-129 Populate project page header with meta data. Introduce ProjectTimelineTable component * NXT-129 Render developedAs project property * NXT-129 Populate full/partially updated products. Add TopicSelectionFurtherInfo and enum for TopicSelectionReason * NXT-129 Create topicSelectionReason enum and render to template * NXT-129 Move project updates to own component. Add null for reasonDecisionText prop * NXT-129 Move stakeholders to own component, add SEO page title and breadcrumbs * NXT-129 Alphabetised props and types * NXT-129 Add todo for register an interest * NXT-129 Iterate topic areas * NXT-129 Setup props and rendering for suspendDisontinued properties * NXT-129 Legacy stakeholders wip * NXT-129 Null type for description * NXT-129 Remove todo comments * NXT-129 Format referral date. Initial setup for unit tests wip * NXT-129 Unit test status complete redirect * NXT-129 Unit test for project not found * NXT-129 Unit test for project id breadcrumb * NXT-129 Add unit test todos * NXT-129 Add further unit tests * NXT-129 Add unit tests for notification date/referral date and pageheader discontinued status * NXT-129 Unit test for topic areas * NXT-129 Unit tests for full/partial update content * NXT-129 Unit test further information link * NXT-129 Render related links in template and unit test * NXT-129 Project id number unit test * NXT-129 Types for legacy stakeholders. Register interest in interventional procedure conditional render and unit test * NXT-129 Unit tests for consultee and commentator stakeholders. Add aria labels for definition lists * NXT-129 Unit test todos * NXT-129 Move suspend discontinued reason to underneath summary * NXT-129 Move topic area list after notification/referral date * NXT-129 Todo for consultation documents button * NXT-129 Unit test project description * NXT-129 Unit test suspend discontinued reason text * NXT-129 Unit test project team * NXT-129 Unit test provisional schedule * NXT-129 Unit test timeline rendering * NXT-129 Unit test project status formatted display name rendering * NXT-129 Remove commented line * NXT-129 Update casing of project status display names * NXT-129 Update querystring for stakeholder and interest register links. Register an interest wip * NXT-129 Set html for timeline and provisional schedule. Finalise register an interest link and unit tests. Update info in paras to definition lists and test * NXT-129 Unit test opposite render logic for register an interest link * NXT-129 Render html in summary and description * NXT-129 Refactor indevelopment slug page - move rendering of project info to separate component * NXT-129 Refactor indevelopment slug page - move rendering of project info to separate component. Add key attrs for lists to resolve console errors around unique keys in render * NXT-129 Refactor register an interest and project status displayname code to use enum type for project status * NXT-129 Wrapper component for definition list styling. Change type for project status to enum * NXT-129 Adjust module styles for definition list wrapper * NXT-129 Move register an interest logic to projectPageHeading component * NXT-129 Render related links as list of working links * NXT-129 Unit test related links heading * NXT-129 Render consultation document links and unit test. Styling and layout * NXT-129 Use existing isTruthy util function in place of notEmpty function * NXT-129 Adjust spacing of definition list items to match existing version. Unset max width on paras to match live version * NXT-129 Linting scss and typescript fixes * NXT-129 Snapshot update * NXT-129 Make project information definition terms and descriptions part of a single definition list. Layout adjustments * NXT-129 Fix odd wrapping on provisional schedule definition list * NXT-129 Minor refactor of props. Move unit tests for ProjectInformation * NXT-129 Apply max-width on paras and definition description elements * NXT-129 Move unit tests for ProjectConsultationDocumentsLink and Stakeholders * NXT-129 Move unit tests for stakeholders and timeline. Remove TODOs and commented out code * NXT-129 Indicator in development project overview tab (#100) * NXT-129 Initial setup for indev overview page including separate validateRouteParams for project * NXT-129 Add 'Complete' type for ProjectStatus. Use ProjectStatus and productPath for redirect * NXT-129 Render project timeline table * NXT-129 Populate project overview with further data * NXT-129 Populate project page header with meta data. Introduce ProjectTimelineTable component * NXT-129 Render developedAs project property * NXT-129 Populate full/partially updated products. Add TopicSelectionFurtherInfo and enum for TopicSelectionReason * NXT-129 Create topicSelectionReason enum and render to template * NXT-129 Move project updates to own component. Add null for reasonDecisionText prop * NXT-129 Move stakeholders to own component, add SEO page title and breadcrumbs * NXT-129 Alphabetised props and types * NXT-129 Add todo for register an interest * NXT-129 Iterate topic areas * NXT-129 Setup props and rendering for suspendDisontinued properties * NXT-129 Legacy stakeholders wip * NXT-129 Null type for description * NXT-129 Remove todo comments * NXT-129 Format referral date. Initial setup for unit tests wip * NXT-129 Unit test status complete redirect * NXT-129 Unit test for project not found * NXT-129 Unit test for project id breadcrumb * NXT-129 Add unit test todos * NXT-129 Add further unit tests * NXT-129 Add unit tests for notification date/referral date and pageheader discontinued status * NXT-129 Unit test for topic areas * NXT-129 Unit tests for full/partial update content * NXT-129 Unit test further information link * NXT-129 Render related links in template and unit test * NXT-129 Project id number unit test * NXT-129 Types for legacy stakeholders. Register interest in interventional procedure conditional render and unit test * NXT-129 Unit tests for consultee and commentator stakeholders. Add aria labels for definition lists * NXT-129 Unit test todos * NXT-129 Move suspend discontinued reason to underneath summary * NXT-129 Move topic area list after notification/referral date * NXT-129 Todo for consultation documents button * NXT-129 Unit test project description * NXT-129 Unit test suspend discontinued reason text * NXT-129 Unit test project team * NXT-129 Unit test provisional schedule * NXT-129 Unit test timeline rendering * NXT-129 Unit test project status formatted display name rendering * NXT-129 Remove commented line * NXT-129 Update casing of project status display names * NXT-129 Update querystring for stakeholder and interest register links. Register an interest wip * NXT-129 Set html for timeline and provisional schedule. Finalise register an interest link and unit tests. Update info in paras to definition lists and test * NXT-129 Unit test opposite render logic for register an interest link * NXT-129 Render html in summary and description * NXT-129 Refactor indevelopment slug page - move rendering of project info to separate component * NXT-129 Refactor indevelopment slug page - move rendering of project info to separate component. Add key attrs for lists to resolve console errors around unique keys in render * NXT-129 Refactor register an interest and project status displayname code to use enum type for project status * NXT-129 Wrapper component for definition list styling. Change type for project status to enum * NXT-129 Adjust module styles for definition list wrapper * NXT-129 Move register an interest logic to projectPageHeading component * NXT-129 Render related links as list of working links * NXT-129 Unit test related links heading * NXT-129 Render consultation document links and unit test. Styling and layout * NXT-129 Use existing isTruthy util function in place of notEmpty function * NXT-129 Adjust spacing of definition list items to match existing version. Unset max width on paras to match live version * NXT-129 Linting scss and typescript fixes * NXT-129 Snapshot update * NXT-129 Make project information definition terms and descriptions part of a single definition list. Layout adjustments * NXT-129 Fix odd wrapping on provisional schedule definition list * NXT-129 Minor refactor of props. Move unit tests for ProjectInformation * NXT-129 Apply max-width on paras and definition description elements * NXT-129 Move unit tests for ProjectConsultationDocumentsLink and Stakeholders * NXT-129 Move unit tests for stakeholders and timeline. Remove TODOs and commented out code * NXT-129 Remove CHTE specific topicSelectionDecistion prop and update snapshots * NXT-129 Update types to use project properties. Unit tests for project utils - wip * NXT-129 Update to param name in project validateRouteParams unit tests - wip * NXT-129 Project utils unit tests wip * NXT-129 Remove comments * NXT-129 Fix unit tests * NXT-129 Update project utils status complete redirect test to more explicit version * NXT-136, NXT-130 Indicator in development project documents tab and document pages (#101) * NXT-130 Initial setup for project documents tab page * NXT-130 Add project.ts utils * NXT-130 Export panels array from validateRouteParams and hasPanels boolean * NXT-130 Render resourcelist from indev resource panels on feed * NXT-130 Filter indev 'History' panel type for project.ts return object * NXT-130 Remove duplicate identifier in ProjectStatus enum * NXT-130 Render resource list lead text and unit test * NXT-130 Populate indev schedule items in props for expected publication date * NXT-130 Populate indev stakeholder registration prop for ProjectPageHeading component * NXT-130 Breadcrumbs wip * NXT-130 Create href path for html and file pages. Unit test * NXT-130 Create correct path in props for files and html * NXT-130 Setup routes for html pages and file streaming * NXT-130 Add project props, project heading component and breadcrumbs for html document page * NXT-130 horizontal nav - needs a projectHorizontalNav component - wip * NXT-130 Setup projectHorizontalNav * NXT-130 Consultations route placeholder * NXT-130 Route for consultations html wip * NXT-130 Refactor consultation urls and move to project utils validateRouteParams for ease of re-use. Render numbered consultation tabs. Correct element type for nds button in project overview page. Hardcode /indicators temporarily in place of /guidance. Move panels logic after status=Complete check for readability * NXT-130 linting * NXT-130 Add projectHorizontalNav for consultations html pages * NXT-130 Remove unused vars * NXT-130 Update unit tests after consultationUrls refactor * NXT-130 Remove console log * NXT-130 Fix unit tests. Remove it.only * NXT-130 Unit test ProjectHorizontalNav * NXT-130 Update page title and breadcrumb with consultation title - wip * NXT-130 Update consultations html page component name * NXT-130 Derive consultation html page title and breadcrumb from consultationUrls * NXT-130 Post merge fixes * NXT-130 Update menu wording and breadcrumb URLs * NXT-130 Fix lint issues * NXT-130 Remove extra consultations breadcrumb There's no 'consultation list' page at /consultations within a project * NXT-130 Lowercase project reference in URL * NXT-130 Add missing horiz nav to project documents * NXT-130 Refactor titles * NXT-130 Fix IPG register link showing for indicators * NXT-130 FIx consultation paths * NXT-130 Fix path of stakeholder reg link * NXT-130 Make list pages use NextJS link * NXT-130 Fix indev doc/download/consultation paths * NXT-130 Remove redundant check and small refactor * NXT-130 Add tests for indev download path * NXT-130 Add test todos * NXT-130 Change breadcrumbs to use NextJS link * NXT-130 Add test todo * NXT-130 Fix documents URL rendering consultations * NXT-130 Allow for external URLs in resources * NXT-130 Fix consultation/document paths * NXT-130 Render panel resources when the HTML resource is empty - e.g. 'https://www.nice.org.uk/guidance/gid-ta11102/documents/html-content-2' * NXT-130 Update unit tests * NXT-130 Unit test consultations resourceTitleId page * NXT-130 Render consultation heading and lastModified date with HTML. Unit test rendering. Request commenting lead permission link conditional rendering - wip * NXT-130 Fix GetServerSidePropsContext type import * NXT-130 Populate shouldUseNewConsultationComments boolean from project utils to conditionally render request commenting lead permission link * NXT-130 Refactorning, add type for IndevconsultationPanel * NXT-130 Refactor in dev resource logic * NXT-130 Change rendering logic for resource file html and resource links as they can appear together. Move resource title so it always renders * NXT-130 Add unit tests for /documents/resourceTitleId page * NXT-130 Remove comments * NXT-130 Add unit tests for breadcrumb and page title on consultation resourceTitleId page * NXT-130 Add unit tests for indicators search list pages --------- Co-authored-by: Ian Routledge <ian.routledge@nice.org.uk> * NXT-144 Indicators snagging list (#102) * NXT-144 Dynamic placholder text wip * NXT-144 Dynamic placeholder attribute rendering and unit tests * Revert "NXT-144 Dynamic placeholder attribute rendering and unit tests" This reverts commit 5f61728. * Revert "NXT-144 Dynamic placholder text wip" This reverts commit 4452695. * NXT-130 Merge commit. Add optional searchInputPlaceholder prop to SearchListFilters to allow different placeholder text between list pages * NXT-144 Update snapshots * NXT-144 Swap niceResultType for resourceType prop in inconsultation and indevelopment list pages * NXT-144 Remove type column from indicators inconsultation list page as resourceType is not currently provided on feed. Map over resource type array on indevelopment list page and separate resourceType string items with a full stop * NXT-144 Conditionally render full stop for resourceType when there is more than 1 * NXT-144-Indicators-snagging-list (#106) * NXT-144 Change useFutureDates boolean so indicator indevelopment/inconsultation list pages allow future date filtering * NXT-144 Update snapshots * NXT-140 Routes and redirects for other non complete statuses (#107) * NXT-140 Added indev urls based on project status * NXT-140 Upgrade next from 12.2.2 to 12.3.4 to fix next bug when using rewrites - see vercel/next.js#40549 and vercel/next.js#38338 * NXT-140 Add project status redirects. Update tests * NXT-140 Delete nodeConfigServerKey and nodeConfigPublicKey before export to resolve warning in terminal about unexpected properties * NXT-140 Fix types for InDevPanel to cover single panel object scenario as well as an array of panels * NXT-154 Add WebdriverIO functional tests for indicators (#109) * NXT-154 Add func tests for indicators * NXT-154 Add depends_on mock search config * NXT-154 Fix tests * NXT-154 Add initial mock publications * NXT-154 Fix hanging tests * NXT-154 Fix exec command on TeamCity * NXT-154 Bump mock APIs to master branch --------- Co-authored-by: Chris Barker <chris.barker@nice.org.uk> Co-authored-by: Ian Routledge <ian.routledge@nice.org.uk> --------- Co-authored-by: Ian Routledge <ian.routledge@nice.org.uk> Co-authored-by: Chris Barker <chris@christopherbarker.co.uk> Co-authored-by: Chris Barker <chris.barker@nice.org.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nicedigital.atlassian.net/browse/NXT-124