Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation is wrong.description is not mandatory for npm. #21

Open
easingthemes opened this issue Dec 23, 2018 · 2 comments
Open

Validation is wrong.description is not mandatory for npm. #21

easingthemes opened this issue Dec 23, 2018 · 2 comments

Comments

@easingthemes
Copy link
Contributor

Only name and version are required fields. description is not mandatory.
https://docs.npmjs.com/files/package.json#version

A lot of packages depending on this one are having wrong data, but because of huge npm registry it's hard to notice.

Related nice-registry/all-the-package-names#12
@zeke
Copy link
Member

zeke commented Dec 24, 2018 •
edited

Thanks for reporting and I'm sorry I haven't made time to look into nice-registry/all-the-package-names#12

I will happily accept a pull request to nice-package and/or all-the-package-names that resolves this, if you have the time.

easingthemes added a commit to easingthemes/nice-package that referenced this issue Dec 24, 2018
@easingthemes
nice-registry#21 remove description field from schema
93c8c8f
easingthemes added a commit to easingthemes/nice-package that referenced this issue Dec 24, 2018
@easingthemes
nice-registry#21 remove test for description
0a6ae92
@easingthemes easingthemes mentioned this issue Dec 24, 2018
Merged
@easingthemes
Copy link
Contributor Author

Thanks for quick response, and great packages.
PR opened #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zeke @easingthemes