Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a seperate example for Windows (--add-image <url>) [Addresses the issue #219] #220

Merged
merged 1 commit into from
Jul 23, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions docs/plugins/classic_plugin.rst
Original file line number Diff line number Diff line change
Expand Up @@ -413,8 +413,10 @@ the tag itself. Let's try that now.
$ eyeD3 --add-image http://example.com/cover.jpg:FRONT_COVER
eyeD3: error: argument --add-image: invalid ImageArg value: 'http://example.com/cover.jpg:FRONT_COVER'

The problem is the ':' character in the the URL, it confuses the format description of the option value. To solve this escape all delimeter characters in
option values with '\\'.
The problem is the ``':'`` character in the the URL, it confuses the format description of the option value. To solve this escape all delimeter characters in
option values with ``'\\'`` (for linux and macOS), single ``'\'`` for Windows).

Linux/MacOS:

.. {{{cog cli_example("examples/cli_examples.sh", "IMG_URL", lang="bash") }}}

Expand All @@ -439,3 +441,28 @@ option values with '\\'.

.. {{{end}}}

Windows:

.. {{{cog cli_example("examples/cli_examples.sh", "IMG_URL", lang="bash") }}}

.. code-block:: bash

$ eyeD3 --add-image http\://example.com/cover.jpg:FRONT_COVER example.id3

C:\Users\user\Downloads\example.id3 [ 0.00 Bytes ]
-------------------------------------------------------------------------------
Adding image http://example.com/cover.jpg
ID3 v2.4:
title:
artist:
album:
album artist: None
track:
FRONT_COVER Image: [Type: -->] [URL: b'http://example.com/cover.jpg']
Description:

Writing ID3 version v2.4
-------------------------------------------------------------------------------

.. {{{end}}}