Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chg: Genre serialization not ID3 v2.3 format by default, and other genre cleanup #402

Merged
merged 12 commits into from Mar 14, 2020
Merged

chg: Genre serialization not ID3 v2.3 format by default, and other genre cleanup #402

merged 12 commits into from Mar 14, 2020

Conversation

nicfit
Copy link
Owner

@nicfit nicfit commented Mar 13, 2020

Addresses #382

@nicfit
.
798b6a8
@nicfit
Merge branch 'master' into genres
cf7e8ee 
* master:
  fix: dev: Removed all 'u' prefixed strings
@nicfit
Merge branch 'master' into genres
ae92876 
* master:
  fix: dev: More u prefix removal
@nicfit
.
78cd693
@nicfit
chg: Deprecated non_std_genre
b242434
@nicfit
Merge branch 'master' into genres
83db807 
* master:
  fix: Date correctness between ID3 versions (#396)
  fix: PopularityFrame email encoding bug.
  new: Support GRP1 (Apple) frames
  new: dev: release prep
  chg: dev: fstrings, python3, display plugin modernize
  chg: dev: python3 updates
  chg: track/disc numbers can be set with integer strings
@nicfit
Merge branch 'master' into genres
3fe2ae7 
* master:
  chg: dev: id3 v2.2 test + cleanup
@nicfit
Genre compare
6416bc1
@nicfit
.
c136957
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling c136957 on genres into 7b632db on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling c136957 on genres into 7b632db on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling c136957 on genres into 7b632db on master.

@coveralls
Copy link

coveralls commented Mar 13, 2020 •
edited

Coverage Status

Coverage remained the same at ?% when pulling 9081779 on genres into 7b632db on master.

@nicfit nicfit linked an issue Mar 13, 2020 that may be closed by this pull request
certain genres still write as ids with non_std_genres #382
Closed
@nicfit nicfit merged commit b0b86b9 into master Mar 14, 2020
@nicfit nicfit deleted the genres branch March 14, 2020 03:42
nicfit added a commit that referenced this pull request Mar 14, 2020
@nicfit
Merge branch 'master' into RVA
2d923f4 
* master:
  new: dev: lameinfo plugin test
  chg: Genre serialization not ID3 v2.3 format by default, and other genre cleanup (#402)
  chg: dev: id3 v2.2 test + cleanup
nicfit added a commit that referenced this pull request Apr 3, 2020
@nicfit
Merge branch 'master' into parcyl
dc84d49 
* master:
  fix: Fixed installation supported Python text
  build(deps-dev): bump pyaml from 19.12.0 to 20.4.0 (#406)
  fix: Implement v1.0/v1.1 tag conversion rules
  new: dev: release prep
  fix: `eyeD3 --genre ""` to clear genre frame restored.
  fix: Genre id->name mapping for non-standard genres and custom maps.
  fix: dev: Plugin index depth
  chg: dev: release prep
  Relative volume adjustments (RVA2 and RVAD) (#399)
  new: dev: lameinfo plugin test
  chg: Genre serialization not ID3 v2.3 format by default, and other genre cleanup (#402)
  chg: dev: id3 v2.2 test + cleanup
  fix: Date correctness between ID3 versions (#396)
  fix: PopularityFrame email encoding bug.
  new: Support GRP1 (Apple) frames
  new: dev: release prep
  chg: dev: fstrings, python3, display plugin modernize
  chg: dev: python3 updates
  chg: track/disc numbers can be set with integer strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

certain genres still write as ids with non_std_genres
2 participants
@nicfit @coveralls