Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #3

Open
nicholaschiasson opened this issue Jul 4, 2023 · 0 comments
Open

Refactor #3

nicholaschiasson opened this issue Jul 4, 2023 · 0 comments

Comments

@nicholaschiasson
Copy link
Owner

Clean up code a bit, for example, expose an Fcidr error type (don't just use the Cidr error type everywhere).

Also investigate ways to improve error handling, removing impossible error scenarios from the code so that not everything needs to return a result. For example, Fcidr::new should not need to return a result, and frankly, neither should Fcidr::include or Fcidr::exclude.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant