Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not generate prefixes for example URIs #21

Merged
merged 2 commits into from Feb 27, 2018

Conversation

kjetilk
Copy link
Contributor

@kjetilk kjetilk commented Feb 23, 2018

Hi!

I got a lot of test failures once the new RDF::NS release made it to CPAN, e.g.
http://www.cpantesters.org/cpan/report/080bc232-1828-11e8-a5bb-b0d86b8adac6

The reason why it breaks is that there seems to be a new prefix alice for http://example.org/
Now, I should possibly have made tests more robust, but when thinking about it, I don't really see any good reason to crowdsource the creation of http://example.org/ , http://example.com/ etc. There shouldn't be any canonical prefix for them, not even one that people agree on... So, I suggest just not set an entry based on those, which is what this patch does.

Please let me know if this is not something you want to do so that I can adjust my tests :-)

Cheers,

Kjetil

@coveralls
Copy link

coveralls commented Feb 23, 2018

Coverage Status

Coverage increased (+0.09%) to 81.553% when pulling 7864646 on kjetilk:feature-band-example into e57fbeb on nichtich:master.

@jonassmedegaard
Copy link

jonassmedegaard commented Feb 21, 2019

Could you please elaborate what kind of problems you experienced?

Also, it seems to me that the currently adopted patch also would also block https://fine-example.jones.dk/

@kjetilk
Copy link
Contributor Author

kjetilk commented Feb 21, 2019

Sorry, I haven't gotten more time, but it would not block that example, just study the regexp in more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants