Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stickyFirstColumn prop #327

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vinicoder
Copy link

@vinicoder vinicoder commented Dec 18, 2023

PR to introduce a new feature where the first column can be sticky.

 <DataSheetGrid
    value={data}
    onChange={setData}
    columns={columns}
    stickyFirstColumn //  Use this to make the first column sticky
 />
CleanShot.2023-12-17.at.11.51.00.mp4

Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for react-datasheet-grid canceled.

Name Link
🔨 Latest commit b402e9a
🔍 Latest deploy log https://app.netlify.com/sites/react-datasheet-grid/deploys/657fb670fc5e3d0008b109ab

@vinicoder vinicoder marked this pull request as ready for review December 18, 2023 03:09
@nick-keller
Copy link
Owner

From what I can see on your video, the selection rectangle behaves strangely. This is a complexe task that might need a deep re-work

@vinicoder
Copy link
Author

From what I can see on your video, the selection rectangle behaves strangely. This is a complexe task that might need a deep re-work

The only issue I see is that the selection rectangle is floating, so it doesn't behave as well as it should with the sticky column. I didn't want to invest much more time in this because first I wanted to know what you think about it, being the project's creator. If you can, test this branch to see how it is; the video can be misleading.

We are using your lib in our project; this is the only missing feature. Do you mind if I create a new NPM package with this PR? We have already tested it, and it will work for our needs.

@Sankarmukesh
Copy link

Hi @nick-keller can we have sticky left option for first 2 columns

@Sankarmukesh
Copy link

@nick-keller @vinicoder can we stop rerendering when datasheetgrid is scrolling is that possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants