Skip to content

Commit

Permalink
Revert "[libc] build with -Werror (llvm#73966)"
Browse files Browse the repository at this point in the history
This reverts commit 6066530.

Post submit buildbots are now red. We can use these explicit errors to better
clean up existing warnings, then reland this.

Link: llvm#73966
  • Loading branch information
nickdesaulniers committed Dec 4, 2023
1 parent 47fe9fc commit 6886a52
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
4 changes: 0 additions & 4 deletions libc/cmake/modules/LLVMLibCObjectRules.cmake
Expand Up @@ -43,10 +43,6 @@ function(_get_common_compile_options output_var flags)
list(APPEND compile_options "-fno-rtti")
list(APPEND compile_options "-Wall")
list(APPEND compile_options "-Wextra")
# -DLIBC_WNO_ERROR=ON if you can't build cleanly with -Werror.
if(NOT LIBC_WNO_ERROR)
list(APPEND compile_options "-Werror")
endif()
list(APPEND compile_options "-Wconversion")
list(APPEND compile_options "-Wno-sign-conversion")
list(APPEND compile_options "-Wimplicit-fallthrough")
Expand Down
8 changes: 0 additions & 8 deletions libc/docs/dev/code_style.rst
Expand Up @@ -178,11 +178,3 @@ these functions do not call the constructors and destructors of the
allocated/deallocated objects. So, use these functions carefully and only
when it is absolutely clear that constructor and destructor invocation is
not required.

Warnings in sources
===================

We expect contributions to be free of warnings from the `minimum supported
compiler versions`__ (and newer).

.. __: https://libc.llvm.org/compiler_support.html#minimum-supported-versions

0 comments on commit 6886a52

Please sign in to comment.