Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add memory leak test #170

Open
nickdesaulniers opened this issue Dec 19, 2016 · 7 comments
Open

add memory leak test #170

nickdesaulniers opened this issue Dec 19, 2016 · 7 comments

Comments

@nickdesaulniers
Copy link
Owner

continuing from issue #151, at commit cfa6ca7 (version 3.2.3) we know we had a memory leak based on running @deepakprabhakara 's leak test https://github.com/redsift/node-nanomsg-leak-test for ~10-20 minutes.

We should find a way to speed up that test, and check it in to our test suite. By checking out the know bad commit (git checkout cfa6ca76b734d2dfeeabd347f2f83bf0c2761d3f), we can verify the test fails fast, and passes on newer versions, once PR #169 is merged.

@deepakprabhakara
Copy link
Contributor

Should be possible if we reduce the timer interval and also create more rep sockets on a range of ports. And nodejs can be run with the '--expose-gc' flag to call global.gc() manually.

@nickdesaulniers
Copy link
Owner Author

I wonder if there's anything we can do to force pressure on the GC, like create a lot of objects?

@deepakprabhakara
Copy link
Contributor

@nickdesaulniers Here's one that leaks within 5 seconds - redsift/node-nanomsg-leak-test@c2835b6

We can do better if needed.

@deepakprabhakara
Copy link
Contributor

Here's a better one - redsift/node-nanomsg-leak-test@7fc0a91

@nickdesaulniers
Copy link
Owner Author

nickdesaulniers commented Dec 20, 2016 via email

@deepakprabhakara
Copy link
Contributor

Sure, I'll try to drop it in as a test and send a PR.

@deepakprabhakara
Copy link
Contributor

I've also added an MIT license in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants