Fix #13: Use bashlex to preprocess substitution commands

[nickdiego]

The following command should work as expected:

compiledb -i sample.txt -o-

• Output:

## Processing build commands from <stdin>
## Writing compilation database with 1 entries to <stdout>
[
 {
  "directory": "/home/nick/projects/compiledb/compiledb-generator",
  "file": "./main.c",
  "arguments": [
   "cc",
   "-DPACKAGE_NAME=\"hello\"",
   "-DPACKAGE_TARNAME=\"hello\"",
   "-DPACKAGE_VERSION=\"1.0.0\"",
   "-DPACKAGE_STRING=\"hello\\ 1.0.0\"",
   "-DPACKAGE_BUGREPORT=\"info@hello.org\"",
   "-DPACKAGE_URL=\"http://www.hello.org\"",
   "-DSTDC_HEADERS=1",
   "-DHAVE_SYS_TYPES_H=1",
   "-DHAVE_SYS_STAT_H=1",
   "-DHAVE_STDLIB_H=1",
   "-DHAVE_STRING_H=1",
   "-DHAVE_MEMORY_H=1",
   "-DHAVE_STRINGS_H=1",
   "-DHAVE_INTTYPES_H=1",
   "-DHAVE_STDINT_H=1",
   "-DHAVE_UNISTD_H=1",
   "-DHAVE_DLFCN_H=1",
   "-DLT_OBJDIR=\".libs/\"",
   "-I-/.",
   "-I-/../../src/libhello",
   "-c",
   "./main.c"
  ]
 }
]
## Done.

• sample.txt

gcc -DPACKAGE_NAME=\"hello\" -DPACKAGE_TARNAME=\"hello\" -DPACKAGE_VERSION=\"1.0.0\" -DPACKAGE_STRING=\"hello\ 1.0.0\" -DPACKAGE_BUGREPORT=\"info@hello.org\" -DPACKAGE_URL=\"http://www.hello.org\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -I. -I../../src/libhello -g -O2 -MT hello_world1-main.o -MD -MP -MF .deps/hello_world1-main.Tpo -c -o hello_world1-main.o `test -f 'main.c' || echo './'`main.c

TODO: There is still an issue with autotools-based builds with the -B, which causes configure script to be executed for every command.

[lyonlh]

Hi @nickdiego ,

I used compile-0.9.1 to verify this issue on xfce4-hardware-monitor-plugin. And encountered some errors. Please refer to the attached log.
compiledb.log

[nickdiego]

I've just setup build environment for xfce-hardware-monitor-plugin and successfully extracted its compilation database, using the following commands:

$ ./configure
$ make -nkw | compiledb

NOTE: I didn't use compiledb make command due to #35
Anyway, I'll investigate that issue, looks like the parser tried to parse (using bashlex) non-valid bash command line from build log entries (most probably some configure script output), what resulted in an non-handled Exception. Just created #38 to track this issue.

Thanks

[lyonlh]

Hi @nickdiego ,

I ran $ make -nkw | compiledb and generated the compilation database same as yours.
But I found an issue about it. There some lines like "-DHARDWARE_MONITOR_GLADEDIR=\"\"/usr/local/share/xfce4-hardware-monitor-plugin/glade/\"\"", which has double \"\" at right side.
In my opinion, the right one is like "-DHARDWARE_MONITOR_GLADEDIR=\"/usr/local/share/xfce4-hardware-monitor-plugin/glade/\"",.

[nickdiego]

It looks like it's being set explicitly to be "double" quoted, at:

src/Makefile.am
44:                        -DHARDWARE_MONITOR_GLADEDIR=\""$(gladedir)/"\" \

I'm not sure about what should be the correct way to handle this.

[lyonlh]

Sure, but the \" would be consumed by shell. It seems bashlex does not evaluate/interpret it.
In my opinion, the result is not reliable if the compile commands are not interpreted by shell. In other words, the arguments shell passes to compiler are definitely wanted.
This is one important reason I wrote https://github.com/lyonlh/ABCD.

[lyonlh]

@nickdiego , I've opened a new issue #40 to track the \"\" issue.