Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix region errors uncovered by rust-lang/rust#27641 #260

Closed
wants to merge 2 commits into from
Closed

Fix region errors uncovered by rust-lang/rust#27641 #260

wants to merge 2 commits into from

Commits on Aug 14, 2015

  1. fix(lifetimes): correct lifetime pattern to separate out server state… 

    … from mw state

Correct lifetimes in response to errors found by rust-lang/rust#27641;
the lifetime parameters on request ('a, 'b, 'k) seem to play the
following roles:

'a, 'b -- these represent the processing of this individual request.
They can vary.

'k -- this represents the lifetime of the server's internal, mutable
storage. It is fixed.

If you only have two parameters 'x and 'y to supply, then, the correct
pattern is `'x, 'x, 'y`, because then `'x` plays the role of the
intersection of `'a` and `'b`, but `'y` is pinned to the server's
internal storage.
    @nikomatsakis
    nikomatsakis committed Aug 14, 2015
    Configuration menu
    Copy the full SHA
    eeb1992 View commit details
    Browse the repository at this point in the history

  2. refactor(lifetimes): change names of lifetimes to be more meaningful 

    Attempt to rename 'a and 'k to something more meaningful. Not sure
that I got this part right.
    @nikomatsakis
    nikomatsakis committed Aug 14, 2015
    Configuration menu
    Copy the full SHA
    82b7f76 View commit details
    Browse the repository at this point in the history