Implements unique in findAll

nicolashohm · Feb 18, 2015 · bd2f70f · bd2f70f
1 parent 2b52c8b
commit bd2f70f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/Storage/File.php b/src/Storage/File.php
@@ -15,7 +15,10 @@ public function __construct($path)
 
     public function findAll()
     {
-        return array_filter(explode(PHP_EOL, file_get_contents($this->path)));
+        $all = explode(PHP_EOL, file_get_contents($this->path));
+        $all = array_filter($all);
+        $all = array_unique($all);
+        return $all;
     }
 
     public function add($user)

diff --git a/test/Networker/Storage/FileTest.php b/test/Networker/Storage/FileTest.php
@@ -57,4 +57,10 @@ public function testAllExisting()
         $this->sut->addAll($this->userList);
         $this->assertEquals($this->userListRaw, file_get_contents($this->file));
     }
+
+    public function testFindAllNoDuplicates()
+    {
+        file_put_contents($this->file, $this->userListRaw . 'octocat' . PHP_EOL);
+        $this->assertEquals($this->userList, $this->sut->findAll());
+    }
 }