catch ratelimit on github

nicolashohm · Feb 15, 2015 · 2b52c8b · 2b52c8b
1 parent 58b622e
commit 2b52c8b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/Network/Github.php b/src/Network/Github.php
@@ -36,7 +36,11 @@ public function userExists($username = null)
     {
         $client = clone $this->httpClient;
         $client->setUri($this->baseUrl . 'users/' . $username);
-        return $client->send()->isSuccess();
+        $response = $client->send();
+        if (!($response->isSuccess() || $response->getStatusCode() == 404)) {
+            throw new \Exception('Unexpected response ' . $response->getStatusCode() . ' ' . $response->getBody());
+        }
+        return $response->isSuccess();
     }
 
     private function fetchUsers($type, $username)

diff --git a/test/Networker/Network/GithubTest.php b/test/Networker/Network/GithubTest.php
@@ -87,4 +87,12 @@ public function provideUserExists()
             [404, false],
         ];
     }
+
+    /**
+     * @expectedException Exception
+     */
+    public function testUserExistsThrowExceptionOnForbidden()
+    {
+        $this->testUserExists(403, false);
+    }
 }