New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More robust Karma tests #43

Closed

Nickersoft opened this issue May 26, 2016 · 1 comment

Labels

Owner

Nickersoft commented May 26, 2016

Sometime in the future, I would like to add more Karma tests to tighten up the testing process. Some examples would be:

Testing the library works on AMD, CommonJS, etc.
Check for more instances in which function calls might return null
Testing certain conditionals work (e.g. the library defaults to using a ServiceWorker if the Notification constructor is not available)

Nickersoft added the enhancement label

Owner Author

Nickersoft commented Aug 18, 2016

Testing improved to satisfactory levels by #59. Will keep in mind for future updates, but for now, closing.

Nickersoft closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment