Allow transparent values to be selected #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 2, 2018 11:43
Adds support for the `none` value as mentioned in this projects readme.txt “Note: you may also use `none` to show a transparent swatch with a checkerboard background.” Without this check `none` options are marked as disabled and cannot be selected
`transparent` is a valid `background-color` value, and will functionally work the same way as `none`.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support allowing
transparentandnonevalues to be selected in the interface.These are valid values for
background-colorthat a user could want to select and as such should be selectable and returnable from the plugin.Currently, any choices using these values are marked as disabled and cannot be selected.